Events triggering refactor #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et-kuzzle-emit-events
Codecov Report
@@ Coverage Diff @@
## 1-dev #1308 +/- ##
=========================================
+ Coverage 93.69% 93.7% +0.01%
=========================================
Files 98 98
Lines 6934 6930 -4
=========================================
- Hits 6497 6494 -3
+ Misses 437 436 -1
Continue to review full report at Codecov.
|
thomasarbona
approved these changes
May 27, 2019
Aschen
approved these changes
May 27, 2019
jenow
approved these changes
May 28, 2019
|
SonarQube analysis reported 1 issue Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
Merged
Aschen
added a commit
that referenced
this pull request
Jun 14, 2019
Release 1.8.0
Bug fixes
[ #1311 ] Fix promise leaks (scottinet)
[ #1298 ] Fix disabled protocol initialization (Aschen)
[ #1297 ] Fix timeouts on plugin action returing the request (benoitvidis)
[ #1288 ] Fix an error when trying a non-partial bulk update (scottinet)
[ #1286 ] Allows bulk inserts on aliases (benoitvidis)
[ #1282 ] Scan keys on redis cluster (benoitvidis)
[ #1279 ] Users must be authenticated to use auth:logout (scottinet)
New features
[ #1315 ] Add the new Vault module to handle encrypted application secrets (Aschen)
[ #1302 ] Add write and mWrite (Aschen)
[ #1305 ] Add pipes & hooks wildcard event (thomasarbona)
Enhancements
[ #1318 ] Add a maximum ttl to auth:login (benoitvidis)
[ #1301 ] Upgrade the WebSocket libraries (scottinet)
[ #1308 ] Events triggering refactor (scottinet)
[ #1300 ] Collection specifications methods cloisoned to a collection (thomasarbona)
[ #1295 ] Improve validation error messages (benoitvidis)
[ #1292 ] Throw an error when the realtime controller is invoked by plugin developers (benoitvidis)
[ #1257 ] Add ability to define mapping policy for new fields (Aschen)
[ #1291 ] Fix --help on subcommands (Yoann-Abbes)
[ #1289 ] Handle ping/pong packets (scottinet)
[ #1273 ] Fix incomplete access logs (scottinet)
Others
[ #1317 ] Add ps dependency to plugin-dev Docker image for pm2 (benoitvidis)
[ #1312 ] Check that .kuzzlerc.sample is well-formed (scottinet)
[ #1299 ] Add Kuzzle Nightly & Redis 3 and 4 test (alexandrebouthinon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not be afraid by the seemingly large number of changed lines, this PR is more simple than it appears.
All it does is this:
kuzzleobject, as an event emitter, trigger events itself (separation of concern)pluginsManager.triggermethod working for both hooks (simple event emissions) and pipes (awaited events returning promises, listened by plugins), we now have the standardkuzzle.emitmethod (synchronous, events are non-blocking), and the newkuzzle.pipeone (async, promise-based, awaited by kuzzle)So, a little bit of code... and a looooooooooot of
kuzzle.pluginsManager.triggerchanged into eitherkuzzle.emitorkuzzle.pipe.Expected benefits:
kuzzleas an event emitter, but with events triggered only by using thepluginsManagerobjectOther changes
validation:errorhook: it isn't documented, and I couldn't find a use for itHow to review
I suggest that you concentrate on reviewing the modifications made to the
lib/kuzzle.jsandlib/api/core/plugins/pluginsManager.jsfiles.Apart from unit tests updates, all other changes are anecdotical (but it's up to you obviously)