Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a maximum ttl to auth:login #1318

Merged
merged 3 commits into from
Jun 11, 2019
Merged

Add a maximum ttl to auth:login #1318

merged 3 commits into from
Jun 11, 2019

Conversation

benoitvidis
Copy link
Contributor

What does this PR do ?

Add a configurable maximum TTL to the login.

internal ref: https://jira.kaliop.net/browse/KZL-1126

@benoitvidis benoitvidis added changelog:securities changelog:new-features Increase the minor version number labels Jun 6, 2019
@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #1318 into 1-dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           1-dev   #1318      +/-   ##
========================================
+ Coverage   93.8%   93.8%   +<.01%     
========================================
  Files         98      98              
  Lines       6991    6992       +1     
========================================
+ Hits        6558    6559       +1     
  Misses       433     433
Impacted Files Coverage Δ
lib/api/controllers/authController.js 95.71% <ø> (ø) ⬆️
...ib/api/core/models/repositories/tokenRepository.js 91.3% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a5774f...5127a43. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #1318 into 1-dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           1-dev   #1318      +/-   ##
========================================
+ Coverage   93.8%   93.8%   +<.01%     
========================================
  Files         98      98              
  Lines       6991    6992       +1     
========================================
+ Hits        6558    6559       +1     
  Misses       433     433
Impacted Files Coverage Δ
...ib/api/core/models/repositories/tokenRepository.js 91.3% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a5d9f9...1feba71. Read the comment docs.

Copy link
Contributor

@Aschen Aschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's more an enhancement than a new-feature

@scottinet scottinet merged commit abf8974 into 1-dev Jun 11, 2019
@scottinet scottinet deleted the kzl-1126-max-ttl branch June 11, 2019 08:29
@Aschen Aschen mentioned this pull request Jun 14, 2019
Aschen added a commit that referenced this pull request Jun 14, 2019
Release 1.8.0

Bug fixes

    [ #1311 ] Fix promise leaks (scottinet)
    [ #1298 ] Fix disabled protocol initialization (Aschen)
    [ #1297 ] Fix timeouts on plugin action returing the request (benoitvidis)
    [ #1288 ] Fix an error when trying a non-partial bulk update (scottinet)
    [ #1286 ] Allows bulk inserts on aliases (benoitvidis)
    [ #1282 ] Scan keys on redis cluster (benoitvidis)
    [ #1279 ] Users must be authenticated to use auth:logout (scottinet)

New features

    [ #1315 ] Add the new Vault module to handle encrypted application secrets (Aschen)
    [ #1302 ] Add write and mWrite (Aschen)
    [ #1305 ] Add pipes & hooks wildcard event (thomasarbona)

Enhancements

    [ #1318 ] Add a maximum ttl to auth:login (benoitvidis)
    [ #1301 ] Upgrade the WebSocket libraries (scottinet)
    [ #1308 ] Events triggering refactor (scottinet)
    [ #1300 ] Collection specifications methods cloisoned to a collection (thomasarbona)
    [ #1295 ] Improve validation error messages (benoitvidis)
    [ #1292 ] Throw an error when the realtime controller is invoked by plugin developers (benoitvidis)
    [ #1257 ] Add ability to define mapping policy for new fields (Aschen)
    [ #1291 ] Fix --help on subcommands (Yoann-Abbes)
    [ #1289 ] Handle ping/pong packets (scottinet)
    [ #1273 ] Fix incomplete access logs (scottinet)

Others

    [ #1317 ] Add ps dependency to plugin-dev Docker image for pm2 (benoitvidis)
    [ #1312 ] Check that .kuzzlerc.sample is well-formed (scottinet)
    [ #1299 ] Add Kuzzle Nightly & Redis 3 and 4 test (alexandrebouthinon)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants