-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ps dependency to plugin-dev Docker image for pm2 #1317
Conversation
Codecov Report
@@ Coverage Diff @@
## 1-dev #1317 +/- ##
=====================================
Coverage 93.8% 93.8%
=====================================
Files 98 98
Lines 6991 6991
=====================================
Hits 6558 6558
Misses 433 433 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## 1-dev #1317 +/- ##
=========================================
- Coverage 93.8% 93.55% -0.26%
=========================================
Files 98 98
Lines 6991 7090 +99
=========================================
+ Hits 6558 6633 +75
- Misses 433 457 +24
Continue to review full report at Codecov.
|
@benoitvidis > I took the liberty to remove the "enhancement" tag for this PR, so that it would be listed in the |
Release 1.8.0 Bug fixes [ #1311 ] Fix promise leaks (scottinet) [ #1298 ] Fix disabled protocol initialization (Aschen) [ #1297 ] Fix timeouts on plugin action returing the request (benoitvidis) [ #1288 ] Fix an error when trying a non-partial bulk update (scottinet) [ #1286 ] Allows bulk inserts on aliases (benoitvidis) [ #1282 ] Scan keys on redis cluster (benoitvidis) [ #1279 ] Users must be authenticated to use auth:logout (scottinet) New features [ #1315 ] Add the new Vault module to handle encrypted application secrets (Aschen) [ #1302 ] Add write and mWrite (Aschen) [ #1305 ] Add pipes & hooks wildcard event (thomasarbona) Enhancements [ #1318 ] Add a maximum ttl to auth:login (benoitvidis) [ #1301 ] Upgrade the WebSocket libraries (scottinet) [ #1308 ] Events triggering refactor (scottinet) [ #1300 ] Collection specifications methods cloisoned to a collection (thomasarbona) [ #1295 ] Improve validation error messages (benoitvidis) [ #1292 ] Throw an error when the realtime controller is invoked by plugin developers (benoitvidis) [ #1257 ] Add ability to define mapping policy for new fields (Aschen) [ #1291 ] Fix --help on subcommands (Yoann-Abbes) [ #1289 ] Handle ping/pong packets (scottinet) [ #1273 ] Fix incomplete access logs (scottinet) Others [ #1317 ] Add ps dependency to plugin-dev Docker image for pm2 (benoitvidis) [ #1312 ] Check that .kuzzlerc.sample is well-formed (scottinet) [ #1299 ] Add Kuzzle Nightly & Redis 3 and 4 test (alexandrebouthinon)
What does this PR do ?
pm2 has an optional dependency on
ps
tool.When pm2 tries to restart a process, for instance if a watched file changes, we get an exception in the log trace (but still manages to restart the service):
How should this be manually tested?
docker build -t kuzzleio/plugin-dev:latest --target plugin-dev .