Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ps dependency to plugin-dev Docker image for pm2 #1317

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

benoitvidis
Copy link
Contributor

What does this PR do ?

pm2 has an optional dependency on ps tool.
When pm2 tries to restart a process, for instance if a watched file changes, we get an exception in the log trace (but still manages to restart the service):

{ Error: spawn ps ENOENT
    at _errnoException (util.js:992:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:190:19)
    at onErrorNT (internal/child_process.js:372:16)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickDomainCallback (internal/process/next_tick.js:218:9)
  code: 'ENOENT',
  errno: 'ENOENT',
  syscall: 'spawn ps',
  path: 'ps',
  spawnargs: [ '-o', 'pid', '--no-headers', '--ppid', 92 ] } 

How should this be manually tested?

  1. Build the image locally
docker build -t kuzzleio/plugin-dev:latest --target plugin-dev .
  1. Test the plugin boiler plate does not throw errors anymore on file change detection.

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #1317 into 1-dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           1-dev   #1317   +/-   ##
=====================================
  Coverage   93.8%   93.8%           
=====================================
  Files         98      98           
  Lines       6991    6991           
=====================================
  Hits        6558    6558           
  Misses       433     433

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a5774f...e71895f. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #1317 into 1-dev will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           1-dev    #1317      +/-   ##
=========================================
- Coverage   93.8%   93.55%   -0.26%     
=========================================
  Files         98       98              
  Lines       6991     7090      +99     
=========================================
+ Hits        6558     6633      +75     
- Misses       433      457      +24
Impacted Files Coverage Δ
lib/api/core/notifier.js 74.13% <0%> (+1.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a5774f...e71895f. Read the comment docs.

@scottinet
Copy link
Contributor

@benoitvidis > I took the liberty to remove the "enhancement" tag for this PR, so that it would be listed in the Others part of our changelogs, since I think it's not really an enhancement. Feel free to put a tag again if you disagree.

@scottinet scottinet merged commit 2a5d9f9 into 1-dev Jun 7, 2019
@scottinet scottinet deleted the docker-dev-procps branch June 7, 2019 07:53
@Aschen Aschen mentioned this pull request Jun 14, 2019
Aschen added a commit that referenced this pull request Jun 14, 2019
Release 1.8.0

Bug fixes

    [ #1311 ] Fix promise leaks (scottinet)
    [ #1298 ] Fix disabled protocol initialization (Aschen)
    [ #1297 ] Fix timeouts on plugin action returing the request (benoitvidis)
    [ #1288 ] Fix an error when trying a non-partial bulk update (scottinet)
    [ #1286 ] Allows bulk inserts on aliases (benoitvidis)
    [ #1282 ] Scan keys on redis cluster (benoitvidis)
    [ #1279 ] Users must be authenticated to use auth:logout (scottinet)

New features

    [ #1315 ] Add the new Vault module to handle encrypted application secrets (Aschen)
    [ #1302 ] Add write and mWrite (Aschen)
    [ #1305 ] Add pipes & hooks wildcard event (thomasarbona)

Enhancements

    [ #1318 ] Add a maximum ttl to auth:login (benoitvidis)
    [ #1301 ] Upgrade the WebSocket libraries (scottinet)
    [ #1308 ] Events triggering refactor (scottinet)
    [ #1300 ] Collection specifications methods cloisoned to a collection (thomasarbona)
    [ #1295 ] Improve validation error messages (benoitvidis)
    [ #1292 ] Throw an error when the realtime controller is invoked by plugin developers (benoitvidis)
    [ #1257 ] Add ability to define mapping policy for new fields (Aschen)
    [ #1291 ] Fix --help on subcommands (Yoann-Abbes)
    [ #1289 ] Handle ping/pong packets (scottinet)
    [ #1273 ] Fix incomplete access logs (scottinet)

Others

    [ #1317 ] Add ps dependency to plugin-dev Docker image for pm2 (benoitvidis)
    [ #1312 ] Check that .kuzzlerc.sample is well-formed (scottinet)
    [ #1299 ] Add Kuzzle Nightly & Redis 3 and 4 test (alexandrebouthinon)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants