Make this plugin compatible with Node.js 10+ #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3-dev #82 +/- ##
=======================================
Coverage 90.69% 90.69%
=======================================
Files 4 4
Lines 548 548
=======================================
Hits 497 497
Misses 51 51
Continue to review full report at Codecov.
|
Aschen
approved these changes
May 29, 2019
alexandrebouthinon
approved these changes
Jun 3, 2019
Yoann-Abbes
approved these changes
Jun 3, 2019
Merged
Aschen
added a commit
that referenced
this pull request
Jun 14, 2019
Bug fixes
[ #78 ] Do not delete existing strategies at start (benoitvidis)
[ #76 ] Strategies in redis (benoitvidis)
Enhancements
[ #82 ] Make this plugin compatible with Node.js 10+ (scottinet)
[ #80 ] Coverage (benoitvidis)
[ #79 ] Readme update (benoitvidis)
Others
[ #77 ] 1st try for functional tests on travis (benoitvidis)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The zmq module is unmaintained for 3 years now, and it's no longer compatible with the latest versions of Node.js
However, a fork of that module has been made a year ago to solve that issue and, since then, the new module grew and is now the new standard to access 0mq with Node.js: zeromq
This PR replaces the zmq module with zeromq. Because it comes from a fork, the API is the same, so the changes are minimal.
Other changes
npm testcommand