Release 3.2.11 #83
Merged
Release 3.2.11 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What does this PR do ? This PR is the fixed version of #74 which, in its original version, would remove the strategies loaded at Kuzzle start -_-;.... ### How should this be manually tested? 1. check the local strategy is still working, for instance by using the admin console 2. test "on-the-flight" strategies addon and removal: - Add this small plugin to your cluster: https://gist.github.com/benoitvidis/a5d9bd592a261d7b903209e73abed59d - Check the `dummy` strategy does not exist by trying to log in - Call http://localhost:7512/_plugin/test/do/bar - Check the `dummy` strategy is known on all nodes - Call http://localhost:7512/_plugin/test/do/foo - Check the `dummy` strategy has been deleted from all nodes Additionally, you can run kuzzle functional tests: 1. switch Kuzzle version to kuzzleio/kuzzle#1284 2. from kuzzle directory, run `./node_modules/.bin/cucumber-js --profile websocketNoRedis` ### Boyscout dependencies upgrade.
## What does this PR do ? This PR fixes a nasty bug where existing strategies would be removed from Kuzzle when the cluster inits itself.
This PR adds functional tests to the cluster stack.
Co-Authored-By: benoitvidis <[email protected]>
Co-Authored-By: benoitvidis <[email protected]>
Readme update
Add nightly functional tests for redis 3, 4 & 5 versions
This PR improves the coverage of unit tests for the cluster.
Description The zmq module is unmaintained for 3 years now, and it's no longer compatible with the latest versions of Node.js However, a fork of that module has been made a year ago to solve that issue and, since then, the new module grew and is now the new standard to access 0mq with Node.js: zeromq This PR replaces the zmq module with zeromq. Because it comes from a fork, the API is the same, so the changes are minimal.
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
===========================================
+ Coverage 57.03% 90.69% +33.65%
===========================================
Files 4 4
Lines 533 548 +15
===========================================
+ Hits 304 497 +193
+ Misses 229 51 -178
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
===========================================
+ Coverage 57.03% 90.69% +33.65%
===========================================
Files 4 4
Lines 533 548 +15
===========================================
+ Hits 304 497 +193
+ Misses 229 51 -178
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.2.11 (2019-06-14)
Bug fixes
Enhancements
Others