Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UDN: Support managedTap binding, bump kubevirt-ipam-controller #1919

Closed
wants to merge 2 commits into from
Closed

UDN: Support managedTap binding, bump kubevirt-ipam-controller #1919

wants to merge 2 commits into from

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Oct 13, 2024 •
edited
Loading

What this PR does / why we need it:
Bump kubevirt-ipam-controller to v0.1.9-alpha
Adapt to support IPAM UDN tests with managedTap binding on CNAO.

Special notes for your reviewer:

Release note:

None

@kubevirt-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 13, 2024
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from oshoval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added size/XS release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 13, 2024
RamLavi
RamLavi reviewed Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for preparing this!

automation/check-patch.e2e-kubevirt-ipam-controller-functests.sh Outdated Show resolved Hide resolved
@oshoval
Copy link
Collaborator Author

oshoval commented Oct 27, 2024

rebased

@oshoval
Copy link
Collaborator Author

oshoval commented Oct 27, 2024

added DynamicPodInterfaceNaming FG

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@oshoval oshoval mentioned this pull request Dec 16, 2024
Merged
@oshoval
Copy link
Collaborator Author

oshoval commented Dec 16, 2024 •
edited
Loading

/cc @RamLavi
seems you will need this, i didn't test it, once ipam-ext is bumped we can test it

also depend on the name we use either l2bridge / manageTap, we might need to change this
EDIT once kubevirt/ipam-extensions#73 is merged we will know the answer for now

@kubevirt-bot kubevirt-bot requested a review from RamLavi December 16, 2024 11:21
@oshoval oshoval mentioned this pull request Dec 16, 2024
Open
RamLavi
RamLavi reviewed Dec 16, 2024
View reviewed changes
automation/check-patch.e2e-kubevirt-ipam-controller-functests.sh
@@ -53,6 +53,8 @@ main() {
deploy_cnao
deploy_cnao_cr
./hack/deploy-kubevirt.sh
./cluster/kubectl.sh -n kubevirt patch kubevirt kubevirt --type=json --patch '[{"op":"add","path":"/spec/configuration/developerConfiguration","value":{"featureGates":[]}},{"op":"add","path":"/spec/configuration/developerConfiguration/featureGates/-","value":"NetworkBindingPlugins"},{"op":"add","path":"/spec/configuration/developerConfiguration/featureGates/-","value":"DynamicPodInterfaceNaming"}]'
./cluster/kubectl.sh -n kubevirt patch kubevirt kubevirt --type=json --patch '[{"op":"add","path":"/spec/configuration/network","value":{"binding":{"managedTap":{"domainAttachmentType":"managedTap","migration":{}}}}}]'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be like this no?

Suggested change
./cluster/kubectl.sh -n kubevirt patch kubevirt kubevirt --type=json --patch '[{"op":"add","path":"/spec/configuration/network","value":{"binding":{"managedTap":{"domainAttachmentType":"managedTap","migration":{}}}}}]'
./cluster/kubectl.sh -n kubevirt patch kubevirt kubevirt --type=json --patch '[{"op":"add","path":"/spec/configuration/network","value":{"binding":{"l2bridge":{"domainAttachmentType":"managedTap","migration":{}}}}}]'

Copy link
Collaborator Author

@oshoval oshoval Dec 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, because kubevirt/ipam-extensions#73 use the first until OVN adapt to 2nd

@oshoval oshoval mentioned this pull request Dec 17, 2024
Closed
@oshoval oshoval marked this pull request as ready for review December 17, 2024 08:40
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2024
@kubevirt-bot kubevirt-bot requested a review from RamLavi December 17, 2024 08:40
@oshoval
Copy link
Collaborator Author

oshoval commented Dec 17, 2024

cherry-picked #1952 here
lets see it pass
else would be glad if you can take it from here please @RamLavi

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@oshoval oshoval changed the title UDN: Support managedTap binding UDN: Support managedTap binding, bump kubevirt-ipam-controller Dec 17, 2024
@oshoval oshoval mentioned this pull request Dec 17, 2024
Closed
@RamLavi
Copy link
Collaborator

RamLavi commented Dec 17, 2024

@oshoval I opened a PR to do the same. Please close this one

@oshoval oshoval closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek Awaiting requested review from phoracek

@qinqon qinqon Awaiting requested review from qinqon

@RamLavi RamLavi Awaiting requested review from RamLavi

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oshoval @kubevirt-bot @RamLavi @web-flow