Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDN: Support managedTap binding, bump kubevirt-ipam-controller #1919

Closed
wants to merge 2 commits into from
Closed

UDN: Support managedTap binding, bump kubevirt-ipam-controller #1919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aba4e1
UDN: Support managedTap binding
oshoval Oct 13, 2024
1ce7dab
bump kubevirt-ipam-controller to v0.1.9-alpha
web-flow Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions automation/check-patch.e2e-kubevirt-ipam-controller-functests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ main() {
deploy_cnao
deploy_cnao_cr
./hack/deploy-kubevirt.sh
./cluster/kubectl.sh -n kubevirt patch kubevirt kubevirt --type=json --patch '[{"op":"add","path":"/spec/configuration/developerConfiguration","value":{"featureGates":[]}},{"op":"add","path":"/spec/configuration/developerConfiguration/featureGates/-","value":"NetworkBindingPlugins"},{"op":"add","path":"/spec/configuration/developerConfiguration/featureGates/-","value":"DynamicPodInterfaceNaming"}]'
./cluster/kubectl.sh -n kubevirt patch kubevirt kubevirt --type=json --patch '[{"op":"add","path":"/spec/configuration/network","value":{"binding":{"managedTap":{"domainAttachmentType":"managedTap","migration":{}}}}}]'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be like this no?

Suggested change
./cluster/kubectl.sh -n kubevirt patch kubevirt kubevirt --type=json --patch '[{"op":"add","path":"/spec/configuration/network","value":{"binding":{"managedTap":{"domainAttachmentType":"managedTap","migration":{}}}}}]'
./cluster/kubectl.sh -n kubevirt patch kubevirt kubevirt --type=json --patch '[{"op":"add","path":"/spec/configuration/network","value":{"binding":{"l2bridge":{"domainAttachmentType":"managedTap","migration":{}}}}}]'

Copy link
Collaborator Author

@oshoval oshoval Dec 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, because kubevirt/ipam-extensions#73 use the first until OVN adapt to 2nd

./cluster/kubectl.sh -n kubevirt patch kubevirt kubevirt --type=merge --patch '{"spec":{"configuration":{"virtualMachineOptions":{"disableSerialConsoleLog":{}}}}}'

cd ${TMP_COMPONENT_PATH}
Expand Down
4 changes: 2 additions & 2 deletions components.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ components:
metadata: v0.45.0
kubevirt-ipam-controller:
url: https://github.com/kubevirt/ipam-extensions
commit: 74c7ef7860f52af37988d6777925c27c79564065
commit: 5e1af1665a9241c92dfc179bf1347630a62f05b8
branch: main
update-policy: tagged
metadata: v0.1.7-alpha
metadata: v0.1.9-alpha
linux-bridge:
url: https://github.com/containernetworking/plugins
commit: 14bdce598f9d332303c375c35719c4a158f1e7db
Expand Down
1 change: 1 addition & 0 deletions data/kubevirt-ipam-controller/001-kubevirtipamcontroller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ spec:
name: cert
readOnly: true
imagePullPolicy: {{ .ImagePullPolicy }}
priorityClassName: system-cluster-critical
securityContext:
runAsNonRoot: true
seccompProfile:
Expand Down
4 changes: 2 additions & 2 deletions pkg/components/components.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ const (
KubeRbacProxyImageDefault = "quay.io/brancz/kube-rbac-proxy@sha256:e6a323504999b2a4d2a6bf94f8580a050378eba0900fd31335cf9df5787d9a9b"
KubeSecondaryDNSImageDefault = "ghcr.io/kubevirt/kubesecondarydns@sha256:8273cdbc438e06864eaa8e47947bea18fa5118a97cdaddc41b5dfa6e13474c79"
CoreDNSImageDefault = "registry.k8s.io/coredns/coredns@sha256:a0ead06651cf580044aeb0a0feba63591858fb2e43ade8c9dea45a6a89ae7e5e"
KubevirtIpamControllerImageDefault = "ghcr.io/kubevirt/ipam-controller@sha256:aad40edd34f65cf0e087969853d47065aaf411dccf618d196152b583d40300ba"
PasstBindingCNIImageDefault = "ghcr.io/kubevirt/passt-binding-cni@sha256:981c01e0b94ae691ba8ced43c486930085186e9c40b22525c8f0229d1556ee69"
KubevirtIpamControllerImageDefault = "ghcr.io/kubevirt/ipam-controller@sha256:41c3a436d871110f995af6d0b3cff7a90fb53a5bad4d4e99ab0954c3e1b79279"
PasstBindingCNIImageDefault = "ghcr.io/kubevirt/passt-binding-cni@sha256:21093fe555e8962f666002258ae3402315fae3d9ec2ae10128529ec0a305bad4"
)

type AddonsImages struct {
Expand Down
4 changes: 2 additions & 2 deletions test/releases/99.0.0.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,13 @@ func init() {
ParentName: "kubevirt-ipam-controller-manager",
ParentKind: "Deployment",
Name: "manager",
Image: "ghcr.io/kubevirt/ipam-controller@sha256:aad40edd34f65cf0e087969853d47065aaf411dccf618d196152b583d40300ba",
Image: "ghcr.io/kubevirt/ipam-controller@sha256:41c3a436d871110f995af6d0b3cff7a90fb53a5bad4d4e99ab0954c3e1b79279",
},
{
ParentName: "passt-binding-cni",
ParentKind: "DaemonSet",
Name: "installer",
Image: "ghcr.io/kubevirt/passt-binding-cni@sha256:981c01e0b94ae691ba8ced43c486930085186e9c40b22525c8f0229d1556ee69",
Image: "ghcr.io/kubevirt/passt-binding-cni@sha256:21093fe555e8962f666002258ae3402315fae3d9ec2ae10128529ec0a305bad4",
},
},
SupportedSpec: cnao.NetworkAddonsConfigSpec{
Expand Down
Loading