Bump ipam to v0.1.9-alpha and enable managed tap #1954
Conversation
kubevirt-bot
added
release-note-none
hack/deploy-kubevirt.sh
Outdated
| @@ -1,6 +1,19 @@ | |||
| #!/bin/bash | |||
| set -exo pipefail | |||
|
|
|||
| if [ -z "${OCI_BIN}" ];then | |||
There was a problem hiding this comment.
this is weird, we concluded at the past that we are doing it once on the bootstrap / locally and not here,
if it is not mandatory please remove it (i mean line 9-11)
There was a problem hiding this comment.
Since we are deploying kubevirt manually at CNAO then we don't do it.
We can alternatively remove the use of this script and use the -kv flag at OVNK.
There was a problem hiding this comment.
IMO deploying kubevirt is part of cluster uping on the lane, so it's totally OK to add this
There was a problem hiding this comment.
we can't add the -kv, because it installs ipam and we dont want to reinstall it
and also want to control what kubevirt version we install
i would say please add it (sysfs) to the git actions once instead, no need each time
(assuming that for local deployment, it can also be done one time on the bare metal)
this what also was decided fwiw when we had same discussions on other repos
There was a problem hiding this comment.
a follow-up can be to adapt OVN to be robust with flags that we can use here, as long as it is nice for both projects
There was a problem hiding this comment.
moreover it is not required for kubevirtci ones, and dont need to be done always, this is another reason it is better please to have it only on the git actions
There was a problem hiding this comment.
Moved it to the automation script so it only involves ipam-ext lane.
RamLavi
force-pushed
the
bump_ipam_with_managedTap
branch
from
9b5a028 to
9f98bb8
Compare
In order to prevent virt-handler crashing on kind cluster on ipam-ext CI, increasing max files on cluster nodes Signed-off-by: Ram Lavi <[email protected]>
Adding this kind flag is need in order to enable the primary UDN feature on OVNK Signed-off-by: Ram Lavi <[email protected]>
Signed-off-by: Ram Lavi <[email protected]>
Signed-off-by: CNAO Bump Bot <[email protected]>
RamLavi
force-pushed
the
bump_ipam_with_managedTap
branch
from
9f98bb8 to
8bf6ddc
Compare
| make cluster-up | ||
|
|
||
| trap teardown EXIT | ||
|
|
||
| increase_ulimit |
|
|
@qinqon PTAL |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
What this PR does / why we need it:
Bump kubevirt-ipam-controller to v0.1.9-alpha
Adapt to support IPAM UDN tests with managedTap binding on CNAO.
Special notes for your reviewer:
Release note: