-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
components/ipam-ext: Remove primary-udn-kubevirt-binding NetworkAttachmentDefinition #1949
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 56755ad. Signed-off-by: Ram Lavi <[email protected]>
This reverts commit ccb7ca2. Signed-off-by: Ram Lavi <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Quality Gate passedIssues Measures |
ClusterRole: "kubevirt-ipam-controller-manager-role", | ||
ClusterRoleBinding: "kubevirt-ipam-controller-manager-rolebinding", | ||
Deployments: []string{"kubevirt-ipam-controller-manager"}, | ||
DaemonSets: []string{"passt-binding-cni"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about removing the ds please ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should be done on a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not mandatory imho, but ok if more comfortable for you
as long as the tests use managedTap before that, else they will fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So perhaps it is better to do it on the PR that bumps ipam-ext?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, orthogonal
passt can be removed after the tests are removed, this way we also each focus on orthogonal parts
as far as possible
flow should be adapt to managedTap,
green to remove passt all over
lets please wait for ipam release and then add #1919 |
why is it on draft though? |
just because didnt test it, need first the release |
@RamLavi: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
passt is no longer the chosen kubevirt binding for primary UDN. Removing the deployment of the
primary-udn-kubevirt-binding
NetworkAttachmentDefinition accordingly.Special notes for your reviewer:
Release note: