Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close shortcodes #39922

Closed
wants to merge 1 commit into from
Closed

Close shortcodes #39922

wants to merge 1 commit into from

Conversation

craigbox
Copy link
Contributor

Hugo v0.111.x will throw an error if shortcodes are not correctly closed. (gohugoio/hugo#10675)
This PR fixes many, if not all, of the cases where they were not closed in the Kubernetes docs.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject language/de Issues or PRs related to German language size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language language/id Issues or PRs related to Indonesian language language/ko Issues or PRs related to Korean language language/uk Issues or PRs related to Ukrainian language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tengqm for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Mar 11, 2023

✅ Pull request preview available for checking

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/640c6a55c00360092dee2b4e
😎 Deploy Preview https://deploy-preview-39922--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tengqm
Copy link
Contributor

tengqm commented Mar 12, 2023

This is an important bug fix, however, we in general don't encourage fixes that span multiple languages.
Could you please split this PR into multiple PRs on a per-language basis?

@craigbox
Copy link
Contributor Author

#39939
#39940
#39941
#39942
#39943
#39944
#39945
#39946
#39947

@craigbox craigbox closed this Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradtopol bradtopol Awaiting requested review from bradtopol

@danninov danninov Awaiting requested review from danninov

Assignees
No one assigned
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/id Issues or PRs related to Indonesian language language/ko Issues or PRs related to Korean language language/uk Issues or PRs related to Ukrainian language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@craigbox @k8s-ci-robot @tengqm