Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] Shortcode fixes #39942

Merged
merged 4 commits into from
Mar 22, 2023
Merged

[ja] Shortcode fixes #39942

merged 4 commits into from
Mar 22, 2023

Conversation

craigbox
Copy link
Contributor

@craigbox craigbox commented Mar 12, 2023 •
edited
Loading

Hugo v0.111.x will throw an error if calling a shortcode within a fenced code block. (gohugoio/hugo#10819)
This PR brings fixes this issue for the ja locale.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 12, 2023
@k8s-ci-robot k8s-ci-robot requested a review from kakts March 12, 2023 21:52
@k8s-ci-robot k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label Mar 12, 2023
@k8s-ci-robot k8s-ci-robot requested a review from ptux March 12, 2023 21:52
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 12, 2023
@craigbox craigbox changed the title [jaShortcode fixes for ja [ja] Shortcode fixes Mar 12, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 12, 2023
@craigbox craigbox mentioned this pull request Mar 12, 2023
Closed
Arhell
Arhell reviewed Mar 13, 2023
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please re-push to restart netlify

@netlify
Copy link

netlify bot commented Mar 14, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c58af8b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/640fdc74caecb60008394941
😎 Deploy Preview https://deploy-preview-39942--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 14, 2023
@craigbox
Copy link
Contributor Author

bump!

t-inu
t-inu reviewed Mar 20, 2023
View reviewed changes
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 37a2e711033f99644fd9c6cf84e31f7f5f686e98

@t-inu
Copy link
Member

t-inu commented Mar 20, 2023

/assign @nasa9084

@nasa9084
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit c64387f into kubernetes:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-inu t-inu t-inu left review comments

@Arhell Arhell Arhell left review comments

@kakts kakts Awaiting requested review from kakts

@ptux ptux Awaiting requested review from ptux

Assignees

@nasa9084 nasa9084

@t-inu t-inu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@craigbox @k8s-ci-robot @t-inu @nasa9084 @Arhell