Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error when shortcode is expected to be closed #10675

Closed
bep opened this issue Jan 31, 2023 · 1 comment
Closed

Throw an error when shortcode is expected to be closed #10675

bep opened this issue Jan 31, 2023 · 1 comment
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.111.0

Comments

@bep
Copy link
Member

bep commented Jan 31, 2023

See #10671

markdown

{{< sc >}}

Bar

layouts/shortcodes/sc.html

{{ .Inner  }}

We throw an error in the other case (a closing tag without .Inner), but the above just fails silently (or: all content below is added as .Inner).
@bep bep self-assigned this Jan 31, 2023
@bep bep removed the NeedsTriage label Jan 31, 2023
This was referenced Jan 31, 2023
Closed
Merged
@bep bep added this to the v0.112.0 milestone Feb 15, 2023
bep added a commit to bep/hugo that referenced this issue Feb 23, 2023
@bep
Throw an error when shortcode is expected to be closed
b6fdff5 
Fixes gohugoio#10675
@bep bep modified the milestones: v0.112.0, v0.111.0 Feb 23, 2023
@bep bep closed this as completed in 7d78a49 Feb 23, 2023
This was referenced Mar 11, 2023
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@altinnadmin altinnadmin mentioned this issue Mar 13, 2023
Merged
@deining deining mentioned this issue Mar 15, 2023
Closed
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.111.0
Development

No branches or pull requests
1 participant
@bep