Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[id] Shortcode fixes #39941

Merged
merged 2 commits into from
Mar 14, 2023
Merged

[id] Shortcode fixes #39941

merged 2 commits into from
Mar 14, 2023

Conversation

craigbox
Copy link
Contributor

Hugo v0.111.x will throw an error if shortcodes are not correctly closed. (gohugoio/hugo#10675)
This PR brings fixes this issue for the id locale.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/id Issues or PRs related to Indonesian language labels Mar 12, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 12, 2023
@craigbox craigbox changed the title [idShortcode fixes for id [id] Shortcode fixes Mar 12, 2023
@craigbox craigbox mentioned this pull request Mar 12, 2023
Closed
habibrosyad
habibrosyad approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@habibrosyad habibrosyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: habibrosyad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 10f13e34d19578030f74781d22d80eb7efb49be4

@netlify
Copy link

netlify bot commented Mar 14, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0812c9b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/640fd549f524420007ef4212
😎 Deploy Preview https://deploy-preview-39941--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot merged commit ede1ad0 into kubernetes:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@habibrosyad habibrosyad habibrosyad approved these changes

@girikuncoro girikuncoro Awaiting requested review from girikuncoro

Assignees

@habibrosyad habibrosyad

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@craigbox @k8s-ci-robot @habibrosyad