Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Change paths of debug pages (case 3) #39528

Merged

Conversation

shogohida
Copy link
Contributor

Fixes #38797

This PR changes the paths of debug pages. The example shown on the issue is below.

  • Change path and add "/ja"
    • e.g.: /docs/tasks/debug-application-cluster/resource-usage-monitoring/ -> /ja/docs/tasks/debug/debug-cluster/resource-usage-monitoring/

@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 19, 2023
@@ -1,6 +1,6 @@
---
reviewers:
-
-
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank space was deleted by Visual Studio Code

@shogohida
Copy link
Contributor Author

@t-inu
I created the last PR! I have a question. There is a wrong path (/docs/tasks/debug-application-cluster/troubleshooting/) in this file but there is not a file called troubleshooting. What should I do?

@netlify
Copy link

netlify bot commented Feb 19, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit fb3b325
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6405e7e26b6b050008ccbbc3
😎 Deploy Preview https://deploy-preview-39528--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@t-inu
Copy link
Member

t-inu commented Feb 20, 2023

@shogohida
The Windows page has been changed by PR #33582, and deleted intro-windows-in-kubernetes.md in English.
When this page existed, it was described as follows.

Your main source of help for troubleshooting your Kubernetes cluster should start with the [Troubleshooting](/docs/tasks/debug/) page.

Currently, I think the following update would be good for Japanese page.

Kubernetesクラスターのトラブルシューティングの主なヘルプソースは、[トラブルシューティング](/ja/docs/tasks/debug/)ページから始める必要があります。

@shogohida
Copy link
Contributor Author

@t-inu
Thanks for your comment! I changed the code so please check it

@@ -5,7 +5,7 @@ content_type: task

<!-- overview -->

Kubernetesアプリケーションは通常、複数の独立したサービスから構成され、それぞれが独自のコンテナで動作しています。これらのサービスをリモートのKubernetesクラスター上で開発・デバッグするには、[get a shell on a running container](/docs/task/debug-application-cluster/get-shell-running-container/)してリモートシェル内でツールを実行しなければならず面倒な場合があります。
Kubernetesアプリケーションは通常、複数の独立したサービスから構成され、それぞれが独自のコンテナで動作しています。これらのサービスをリモートのKubernetesクラスター上で開発・デバッグするには、[get a shell on a running container](/ja/docs/task/debug/debug-application/get-shell-running-container/)してリモートシェル内でツールを実行しなければならず面倒な場合があります。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Kubernetesアプリケーションは通常、複数の独立したサービスから構成され、それぞれが独自のコンテナで動作しています。これらのサービスをリモートのKubernetesクラスター上で開発・デバッグするには、[get a shell on a running container](/ja/docs/task/debug/debug-application/get-shell-running-container/)してリモートシェル内でツールを実行しなければならず面倒な場合があります。
Kubernetesアプリケーションは通常、複数の独立したサービスから構成され、それぞれが独自のコンテナで動作しています。これらのサービスをリモートのKubernetesクラスター上で開発・デバッグするには、[実行中のコンテナへのシェルを取得](/ja/docs/tasks/debug/debug-application/get-shell-running-container/)してリモートシェル内でツールを実行しなければならず面倒な場合があります。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review! I fixed the content 🙇

c6809f4

Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 303db50c6ad1bd0500123f4c5c9947ceee61f41e

@t-inu
Copy link
Member

t-inu commented Feb 27, 2023

/assign @nasa9084

@@ -387,7 +387,7 @@ GAになってからさらなる変更を加えることは現実的ではない
- `CustomResourceWebhookConversion`: [CustomResourceDefinition](/docs/concepts/extend-kubernetes/api-extension/custom-resources/)から作成されたリソースのWebhookベースの変換を有効にします。
- `DevicePlugins`: [device-plugins](/docs/concepts/cluster-administration/device-plugins/)によるノードでのリソースプロビジョニングを有効にします。
- `DryRun`: サーバーサイドでの[dry run](/docs/reference/using-api/api-concepts/#dry-run)リクエストを有効にします。
- `DynamicAuditing`: [動的監査](/docs/tasks/debug-application-cluster/audit/#dynamic-backend)を有効にします。
- `DynamicAuditing`: [動的監査](/docs/tasks/debug/debug-cluster/audit/#dynamic-backend)を有効にします。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just information.
It's not the target of this PR.
This PR looks ok for me.

DynamicAuditing is deprecated on 1.19 and removed as of now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't know that. Thanks for your information!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a few:sweat_smile: pages needed to be updated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DynamicAuditing doesn't exist in the latest English Feature Gates page.
In Japanese page, the description is still there, just deleted from the list.
So, whether fix the link or not, this line will be deleted eventually in Japanese, too.
I think delete this line by this PR is also good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was good to delete this line so I deleted it. Please review again 🙇

5164429

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2023
@t-inu
Copy link
Member

t-inu commented Mar 1, 2023

@shogohida
Deploy failed has occurred.
The build log is similar to the following comment.
#39479 (comment)

And this comment may help you.

Try rebasing this PR against main.

#39479 (comment)

@shogohida shogohida force-pushed the fix-debug-application-cluster-paths branch from 5164429 to 00c49bd Compare March 3, 2023 12:02
@t-inu
Copy link
Member

t-inu commented Mar 6, 2023

The cause of the error has changed.
"Build exceeded maximum allowed runtime"
Here is a same case.
#39479 (comment)

@atoato88
Copy link
Contributor

atoato88 commented Mar 6, 2023

@shogohida

"Build exceeded maximum allowed runtime"

Could you create some updates to this PR for kick the rebuild on Netlify?
I experienced same error message on other PR and fixed by rebuilding.

Signed-off-by: Shogo Hida <[email protected]>
@shogohida shogohida force-pushed the fix-debug-application-cluster-paths branch from 00c49bd to fb3b325 Compare March 6, 2023 13:17
@shogohida
Copy link
Contributor Author

@t-inu @atoato88
Thanks for your comments! I made an empty commit and pushed it and checks passed!

@atoato88
Copy link
Contributor

atoato88 commented Mar 6, 2023

Yes, it looks success to build.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4ca31840861b483b45ee92838e5a6b7634c6e585

Copy link
Member

@nasa9084 nasa9084 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084, t-inu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 14639c6 into kubernetes:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] Some links to debug page are outdated
5 participants