Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Some links to debug page are outdated #38797

Closed
t-inu opened this issue Jan 6, 2023 · 11 comments · Fixed by #38884, #39020 or #39528
Closed

[ja] Some links to debug page are outdated #38797

t-inu opened this issue Jan 6, 2023 · 11 comments · Fixed by #38884, #39020 or #39528
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/ja Issues or PRs related to Japanese language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@t-inu
Copy link
Member

t-inu commented Jan 6, 2023

This is a Feature Request

What would you like to be added
PR #34162 changed the location of some .md files.
We need to update the links to those pages.

Why is this needed
Because the links are broken and the pages cannot be referenced.
Also, we can change some links to English page to Japanese page.

I checked "/docs/tasks/debug" by using grep command.
There are many links that need to be updated.
I would like to divide them into three cases, and create each PRs for easier to review.

  • Only add "/ja"
    • e.g.: /docs/tasks/debug/debug-cluster/audit/ -> /ja/docs/tasks/debug/debug-cluster/audit/
  • Change path
    • e.g.: /ja/docs/tasks/debug-application-cluster/audit/ -> /ja/docs/tasks/debug/debug-cluster/audit/
  • Change path and add "/ja"
    • e.g.: /docs/tasks/debug-application-cluster/resource-usage-monitoring/ -> /ja/docs/tasks/debug/debug-cluster/resource-usage-monitoring/

Comments
/language ja
/assign

@t-inu t-inu added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 6, 2023
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 6, 2023
@k8s-ci-robot
Copy link
Contributor

@t-inu: This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shogohida
Copy link
Contributor

Hi @t-inu, can I work on this? I'm generally new to the Kubernetes community and I want to contribute to this

@t-inu
Copy link
Member Author

t-inu commented Jan 11, 2023

/assign @shogohida
I'm glad to see your positive action.
Please try to create one PR, first.

@shogohida
Copy link
Contributor

Thanks for your comment! I will try to create a pull request as soon as possible as you said

@shogohida
Copy link
Contributor

I created a first PR! 2 reviewers were already assigned but I share this here too just in case

#38884

@t-inu
Copy link
Member Author

t-inu commented Jan 17, 2023

/reopen
Two cases still remain.

@k8s-ci-robot
Copy link
Contributor

@t-inu: Reopened this issue.

In response to this:

/reopen
Two cases still remain.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@t-inu
Copy link
Member Author

t-inu commented Feb 3, 2023

/reopen
Only one case remains.

@k8s-ci-robot
Copy link
Contributor

@t-inu: Reopened this issue.

In response to this:

/reopen
Only one case remains.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Feb 3, 2023
@t-inu
Copy link
Member Author

t-inu commented Feb 15, 2023

@shogohida
Are you working on the last case?
There is no hurry, but I'd like to know if you plan to create a PR for it.

@shogohida
Copy link
Contributor

@t-inu
Oh, sorry for missing the last one 🙇 I will try to create a PR as soon as possible (maybe tomorrow or this weekend)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/ja Issues or PRs related to Japanese language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
3 participants