Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Translate title and linkTitle for Blogs page #39650

Merged
merged 4 commits into from
Mar 8, 2023

Conversation

Saliha067
Copy link
Contributor

@Saliha067 Saliha067 commented Feb 24, 2023

Improvement suggestions for the following

  • Blogs --> Kubernetesブログ
  • The preview page: Link

Screenshot 2023-02-24 at 2 36 41 PM

Screenshot 2023-02-24 at 2 37 12 PM

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2023
@k8s-ci-robot k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label Feb 24, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 24, 2023
@Saliha067 Saliha067 changed the title Blogspage jp [JP] Blogs page Feb 24, 2023
@netlify
Copy link

netlify bot commented Feb 24, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ca59f53
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/640599fcbc8a070008c2bbdb
😎 Deploy Preview https://deploy-preview-39650--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sftim
Copy link
Contributor

sftim commented Feb 24, 2023

LGTM

Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This is a good point of view.

Comment on lines 2 to 10
linktitle: Kubernetesブログ
title: Kubernetesブログ
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
linktitle: Kubernetesブログ
title: Kubernetesブログ
---
title: Kubernetesブログ
linkTitle: ブログ
menu:
main:
title: "ブログ"
weight: 40
post: >
<p>Kubernetesやコンテナ全般に関する最新ニュースを読んで、技術的なハウツーをいち早く入手しましょう。</p>
---
{{< comment >}}
ブログへの寄稿についての情報は、以下を参照してください
https://kubernetes.io/docs/contribute/new-content/blogs-case-studies/#write-a-blog-post
{{< /comment >}}

I think it's better to match the following original file.

---
title: Kubernetes Blog
linkTitle: Blog
menu:
main:
title: "Blog"
weight: 40
post: >
<p>Read the latest news for Kubernetes and the containers space in general, and get technical how-tos hot off the presses.</p>
---
{{< comment >}}
For information about contributing to the blog, see
https://kubernetes.io/docs/contribute/new-content/blogs-case-studies/#write-a-blog-post
{{< /comment >}}

@t-inu
Copy link
Member

t-inu commented Mar 3, 2023

I tested where these fields are used.

---
title: Kubernetesブログ(title)
linkTitle: ブログ(linkTitle)
menu:
  main:
    title: "ブログ(title-in-main)"
    weight: 40
    post: >
       <p>Kubernetesやコンテナ全般に関する最新ニュースを読んで、技術的なハウツーをいち早く入手しましょう。</p>
---

image

image

image

I don't know where the title field in the main is used, but it would be good to keep it the same as the original file.

@t-inu
Copy link
Member

t-inu commented Mar 3, 2023

/retitle [ja] Translate title and linkTitle for Blogs page

@k8s-ci-robot k8s-ci-robot changed the title [JP] Blogs page [ja] Translate title and linkTitle for Blogs page Mar 3, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2023
@Saliha067 Saliha067 requested review from t-inu and removed request for bells17 and kakts March 3, 2023 10:51
@Saliha067
Copy link
Contributor Author

Saliha067 commented Mar 3, 2023

@sftim @t-inu can you please take a look?

@t-inu
Copy link
Member

t-inu commented Mar 6, 2023

I seem the modified file is fine.
We'd like to solve Netlify's deploy failed.
The following comment may be helpful to you.
#39528 (comment)

Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error no longer occurs.
Currently, the modifications can be checked on the preview site.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 31a46d81bf6b30a9905fcaa210ace2bf6d5b17c4

@t-inu
Copy link
Member

t-inu commented Mar 6, 2023

/assign @inductor @nasa9084

Copy link
Member

@nasa9084 nasa9084 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit a23997a into kubernetes:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants