Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Korean l10n guide #17402

Merged
merged 2 commits into from
Nov 6, 2019
Merged

Update Korean l10n guide #17402

merged 2 commits into from
Nov 6, 2019

Conversation

gochist
Copy link
Member

@gochist gochist commented Nov 4, 2019 •
edited
Loading

  1. "용어" 소제목 아래 기술되었던 용어와 관련된 원칙을 "문체" 소제목 이하로 재구성
  2. API 오브젝트의 필드 이름 관련 원칙 일부 수정
  3. 외래어 표기법 깨진 링크 업데이트
  4. 전문(front-matter) 내 불필요한 구분자(---) 삭제

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 4, 2019
@gochist
Copy link
Member Author

gochist commented Nov 4, 2019

/assign @seokho-son

@netlify
Copy link

netlify bot commented Nov 4, 2019 •
edited
Loading

Deploy preview for k8s-dev-ko ready!

Built with commit 33df8f0

https://deploy-preview-17402--k8s-dev-ko.netlify.com

seokho-son
seokho-son reviewed Nov 5, 2019
View reviewed changes
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gochist 감사합니다. 사소한 의견 드립니다.. :)
참고하시고, 필요에 따라 업데이트 부탁 드립니다.

content/ko/docs/contribute/localization_ko.md Outdated Show resolved Hide resolved
content/ko/docs/contribute/localization_ko.md Outdated Show resolved Hide resolved
content/ko/docs/contribute/localization_ko.md Outdated Show resolved Hide resolved
@gochist
Copy link
Member Author

gochist commented Nov 5, 2019

@seokho-son 감사합니다! 의견 주신 내용 반영했습니다.

@seokho-son
Copy link
Member

@gochist 감사합니다 !
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 353d4b6 into kubernetes:dev-1.16-ko.4 Nov 6, 2019
seokho-son added a commit that referenced this pull request Nov 8, 2019
@ysyukr @lapee79
@gochist @seokho-son
Forth Korean l10n work for release-1.16
0811d3e 
* Translate workloads/controllers/ttlafterfinished.md in Korean. (#17241)
* Update Korean l10n guide (#17402)
* Translate tasks/manage-kubernetes-objects/kustomization in Korean (#17225)
* Update file outdated korean docs in dev-1.16-ko.4 (#17235)
* Translate concepts/workloads/pods/ephemeral-containers.md in Korean. (#16630)

Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: Cheolgu Kim <[email protected]>
Co-Authored-By: June Yi <[email protected]>
Co-Authored-By: Seokho Son <[email protected]>
@seokho-son seokho-son mentioned this pull request Nov 8, 2019
Merged
k8s-ci-robot pushed a commit that referenced this pull request Nov 8, 2019
@seokho-son @ysyukr
@lapee79 @gochist @k8s-ci-robot
Forth Korean l10n work for release-1.16 (#17481)
3c38315 
* Translate workloads/controllers/ttlafterfinished.md in Korean. (#17241)
* Update Korean l10n guide (#17402)
* Translate tasks/manage-kubernetes-objects/kustomization in Korean (#17225)
* Update file outdated korean docs in dev-1.16-ko.4 (#17235)
* Translate concepts/workloads/pods/ephemeral-containers.md in Korean. (#16630)

Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: Cheolgu Kim <[email protected]>
Co-Authored-By: June Yi <[email protected]>
Co-Authored-By: Seokho Son <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seokho-son seokho-son seokho-son left review comments

@claudiajkang claudiajkang Awaiting requested review from claudiajkang

Assignees

@seokho-son seokho-son

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gochist @seokho-son @k8s-ci-robot