Update file outdated korean docs in dev-1.16-ko.4 #17235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
language/ko
k8s-ci-robot
added
the
sig/docs
|
/assign @ianychoi |
|
Deploy preview for k8s-dev-ko ready! Built with commit b4bd418 |
|
/unassign @ianychoi |
seokho-son
reviewed
Nov 6, 2019
There was a problem hiding this comment.
@ysyukr Thank you for managing outdated contents 👍
I have a few minor comments on this PR. Please take a look and apply them if necessary.
content/ko/docs/concepts/overview/working-with-objects/names.md
Outdated
Show resolved
Hide resolved
content/ko/docs/concepts/overview/working-with-objects/names.md
Outdated
Show resolved
Hide resolved
content/ko/docs/concepts/overview/working-with-objects/names.md
Outdated
Show resolved
Hide resolved
content/ko/docs/concepts/overview/working-with-objects/names.md
Outdated
Show resolved
Hide resolved
content/ko/docs/concepts/overview/working-with-objects/names.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Seokho Son <[email protected]>
|
@seokho-son Thank you for the review. I've checked and reflected your suggestions. |
|
@ysyukr Thank you ! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: seokho-son The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
seokho-son
added a commit
that referenced
this pull request
Nov 8, 2019
* Translate workloads/controllers/ttlafterfinished.md in Korean. (#17241) * Update Korean l10n guide (#17402) * Translate tasks/manage-kubernetes-objects/kustomization in Korean (#17225) * Update file outdated korean docs in dev-1.16-ko.4 (#17235) * Translate concepts/workloads/pods/ephemeral-containers.md in Korean. (#16630) Co-Authored-By: Yuk, Yongsu <[email protected]> Co-Authored-By: Cheolgu Kim <[email protected]> Co-Authored-By: June Yi <[email protected]> Co-Authored-By: Seokho Son <[email protected]>
k8s-ci-robot
pushed a commit
that referenced
this pull request
Nov 8, 2019
* Translate workloads/controllers/ttlafterfinished.md in Korean. (#17241) * Update Korean l10n guide (#17402) * Translate tasks/manage-kubernetes-objects/kustomization in Korean (#17225) * Update file outdated korean docs in dev-1.16-ko.4 (#17235) * Translate concepts/workloads/pods/ephemeral-containers.md in Korean. (#16630) Co-Authored-By: Yuk, Yongsu <[email protected]> Co-Authored-By: Cheolgu Kim <[email protected]> Co-Authored-By: June Yi <[email protected]> Co-Authored-By: Seokho Son <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
14 out of 20 files to be modified
Unmodified document and reason.
from #17187
/language ko