Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs-fr | Website Homepage #12789

Merged
merged 4 commits into from
Mar 1, 2019
Merged

docs-fr | Website Homepage #12789

merged 4 commits into from
Mar 1, 2019

Conversation

jygastaud
Copy link
Contributor

@jygastaud jygastaud commented Feb 22, 2019 •
edited
Loading

No description provided.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2019
@k8s-ci-robot k8s-ci-robot added the language/fr Issues or PRs related to French language label Feb 22, 2019
@jygastaud
Copy link
Contributor Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 22, 2019
@netlify
Copy link

netlify bot commented Feb 22, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 7ff1273

https://deploy-preview-12789--kubernetes-io-master-staging.netlify.com

@jygastaud jygastaud marked this pull request as ready for review February 22, 2019 15:19
remyleone
remyleone reviewed Feb 22, 2019
View reviewed changes
content/fr/_index.html Outdated Show resolved Hide resolved
@jygastaud jygastaud changed the title docs-fr | Website Homepage WIP : docs-fr | Website Homepage Feb 22, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2019
@jygastaud
Copy link
Contributor Author

Bot fails because /docs/concepts/overview/what-is-kubernetes not exists.

Translation is in progress in #12799

@remyleone
Copy link
Contributor

@jygastaud On peut avoir des use-cases en français :) Donc je pense qu'il faut garder le lien

@jygastaud
Copy link
Contributor Author

@jygastaud On peut avoir des use-cases en français :) Donc je pense qu'il faut garder le lien

Case-studies block is back.

@jygastaud jygastaud force-pushed the fr_website_homepage branch 2 times, most recently from 1e41c08 to a44fe9c Compare February 25, 2019 21:45
@remyleone
Copy link
Contributor

I get :

Building sites … ERROR 2019/02/26 11:02:43 [fr] No case-studies section found. Create content/fr/case-studies/_index.md
Total in 4125 ms
Error: Error building site: logged 1 error(s)

How could I build the website?

@jygastaud
Copy link
Contributor Author

I get :

Building sites … ERROR 2019/02/26 11:02:43 [fr] No case-studies section found. Create content/fr/case-studies/_index.md
Total in 4125 ms
Error: Error building site: logged 1 error(s)

How could I build the website?

Erf. It's the {{< blocks/case-studies >}} that make the build failed.

So 2 ways to build right now.

  1. Remove the block again
  2. Make a quick copy (then translate) of case-studies/_index.html page into fr/ folder

@jygastaud jygastaud force-pushed the fr_website_homepage branch 2 times, most recently from d5ef346 to 3c90bef Compare February 27, 2019 07:52
@jygastaud
Copy link
Contributor Author

jygastaud commented Feb 27, 2019 •
edited
Loading

I've added some strings translation to translate the kubeweekly newsletter block.
The translation should work once #12873 is merged

@jygastaud jygastaud changed the title WIP : docs-fr | Website Homepage docs-fr | Website Homepage Feb 27, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2019
rekcah78
rekcah78 reviewed Feb 27, 2019
View reviewed changes
i18n/fr.toml Outdated Show resolved Hide resolved
@rekcah78
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2019
@remyleone
Copy link
Contributor

/lgtm

@remyleone
Copy link
Contributor

/approve

yastij
yastij approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@yastij
Copy link
Member

yastij commented Feb 27, 2019

/assign @cody-clark

@jygastaud
Copy link
Contributor Author

Anyone in @kubernetes/sig-docs-en-owners who can unlock that PR ?

@zacharysarah
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sieben, yastij, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit ad6f156 into kubernetes:master Mar 1, 2019
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
@jygastaud
docs-fr | Website Homepage (kubernetes#12789)
48174bc 
* Translate website homepage to french

* Translate case-studies index page into french

* Translate kubeweekly block into french

* Fix translation of Kubernetes features title into french
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@jygastaud @yagonobre
docs-fr | Website Homepage (kubernetes#12789)
8459791 
* Translate website homepage to french

* Translate case-studies index page into french

* Translate kubeweekly block into french

* Fix translation of Kubernetes features title into french
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekcah78 rekcah78 rekcah78 left review comments

@remyleone remyleone remyleone left review comments

@yastij yastij yastij approved these changes

Assignees

@remyleone remyleone

@rekcah78 rekcah78

@yastij yastij

@cody-clark cody-clark

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/fr Issues or PRs related to French language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jygastaud @k8s-ci-robot @remyleone @rekcah78 @yastij @zacharysarah @cody-clark