Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs-fr | overview | what is kubernetes #12799

Merged

Conversation

jygastaud
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2019
@k8s-ci-robot k8s-ci-robot added the language/fr Issues or PRs related to French language label Feb 22, 2019
@netlify
Copy link

netlify bot commented Feb 22, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 3e4438a

https://deploy-preview-12799--kubernetes-io-master-staging.netlify.com

@jygastaud jygastaud force-pushed the fr_overview_what-is-kubernetes branch 3 times, most recently from 5b01e0d to f7c9d5b Compare February 25, 2019 13:52
@jygastaud jygastaud changed the title WIP: docs-fr | overview | what is kubernetes docs-fr | overview | what is kubernetes Feb 25, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2019
@jygastaud jygastaud force-pushed the fr_overview_what-is-kubernetes branch from f7c9d5b to 9ade72c Compare February 25, 2019 14:01
Copy link
Contributor

@remyleone remyleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques typos

content/fr/docs/concepts/overview/what-is-kubernetes.md Outdated Show resolved Hide resolved
content/fr/docs/concepts/overview/what-is-kubernetes.md Outdated Show resolved Hide resolved
content/fr/docs/concepts/overview/what-is-kubernetes.md Outdated Show resolved Hide resolved
content/fr/docs/concepts/overview/what-is-kubernetes.md Outdated Show resolved Hide resolved
content/fr/docs/concepts/overview/what-is-kubernetes.md Outdated Show resolved Hide resolved
content/fr/docs/concepts/overview/what-is-kubernetes.md Outdated Show resolved Hide resolved
content/fr/docs/concepts/overview/what-is-kubernetes.md Outdated Show resolved Hide resolved
content/fr/docs/concepts/overview/what-is-kubernetes.md Outdated Show resolved Hide resolved
content/fr/docs/concepts/overview/what-is-kubernetes.md Outdated Show resolved Hide resolved
content/fr/docs/concepts/overview/what-is-kubernetes.md Outdated Show resolved Hide resolved
@jygastaud jygastaud force-pushed the fr_overview_what-is-kubernetes branch from e9e6c50 to 9d84c56 Compare February 25, 2019 15:35
@jygastaud jygastaud force-pushed the fr_overview_what-is-kubernetes branch from 9d84c56 to 3e4438a Compare February 25, 2019 15:59
@lledru
Copy link
Contributor

lledru commented Feb 25, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lledru

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2019
@rekcah78
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 99dccca into kubernetes:master Feb 25, 2019
reviewers:
- bgrant0607
- mikedanese
- jygastaud
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why include these reviewers? They are not in the sig-docs-fr-* OWNERS file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I forgot to change it. They came from the EN file.
Will open a new PR with the change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for that 🙂

kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/fr Issues or PRs related to French language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants