-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EasyCLA Feedback & Issues #3068
Comments
/cc @anusha94 |
This came up on the k/website Official 1.23 Release Docs PR we use to merge PRs from the k/website |
I've signed CLA since mid-2018, but got this error on EasyCLA today: kubernetes-sigs/scheduler-plugins#290 (comment) Updated: My company's CLA approver approved my easyCLA request, and the above CR shows green. However, another PR doesn't, even I tried the "Not Covered" button for a few times. |
I am covered by a corporate CLA, but I am getting this error kubernetes/kops#12743 (comment) |
I am also covered by a corporate CLA, but I am getting this error for kubernetes/autoscaler#4131 (comment) |
one more kubernetes/kubernetes#106436 |
@mrbobbytables It appears there was no automatic migration of existing folks who had approval. I am having to manually add each person to the new easyCLA access list. For all IBM employees that are running into this issue please contact me on our internal slack and I will add you to the easyCLA. |
@bradtopol For now, don't worry about adding them 1-by-1, its non-blocking and they can ignore it til the issues are sorted out. |
@pranab-bajpai is there working going on to fix this? I'd like to follow along, looks like slack channel is totally silent and no updates from the easycla team on this issue either. Could we please work in the open? cc @caniszczyk |
Really? Folks keep telling me its blocking their PRs. |
@bradtopol yup. It's been rolled out in non-blocking mode. The old CLA is still the source of truth. If they have the label |
kubernetes/website#30504 (comment) suggests a mismatch between the new and old bots. |
I am also covered by a corporate CLA, but I am getting this error: kubernetes/perf-tests#1935 |
I am also running into this: kubernetes/kubernetes#96120 (comment) |
I also was confused by this. I did not test whether it is blocking, @bradtopol migrated me. @dumb0002 : FYI, I see the cncf CLA is green checked on your PR. |
@MikeSpreitzer: yes, as long as we have the cncf-cla: yes label we are good to go. But still I am reporting it here as suggested by @bradtopol |
Yes, any instance where we a discrepancy between the two CLA systems should be logged. 👍 |
/cc |
#3101 (comment) gets it wrong, I do have a corporate CLA sign off. |
@sftim the new cla is a github app and will require authorization. However it should have synced for you. Don't worry about signing it till that issue is sorted out. |
Feedback on behavior: I opened a PR in k/website against the kubernetes/website#30502 (comment) I think this could have all been avoided if I swapped the base branch in the GH GUI first, THEN force pushed the commits (re-triggering an EasyCLA check). I'm assuming (hoping? guessing?) my next force push will resolve it. |
@jimangel either order would have triggered similar behavior here I'm afraid. Changing the base branch first would have triggered CLA checks for all commits not shared between the two merge bases. |
What I'd like GitHub to let you do: change the merge base during a forced push using a Git push option (GitLab has features for this, I don't think GitHub does). IMO that's more an issue with atomically changing the merge base during a forced push and less about EasyCLA. |
I could have been lucky with timing, but I did update the base branch (saw all the commits appear in the GH GUI) and reverted back, which didn't trigger EasyCLA. First time: Second time: The difference being a force push the second time that included commits not in I don't know for sure, but I'm guessing EasyCLA triggers on push events vs. GH UI actions (like switching base branches)? |
We had more that came up in a PR to sync the |
Hi folks, |
I signed the old CLA in 2019, and signed again when EasyCLA came out. EasyCLA is now failing again (between commits) on this PR: kubernetes-sigs/cluster-api#5735 |
Same issue with EasyLCA on my PR: |
EasyCLA didn't like my squash-and-forced-push: kubernetes/website#29685 (comment) |
Is there a simple way of checking my own CLA status (both)? A button or form perhaps? |
I am covered by a corporate CLA, but I am getting this error for kubernetes-sigs/cluster-api/pull/5806 |
Hi All, Thanks, |
Only Project Managers can see if a user has signed CLA or not in the Project Control Center admin view of EasyCLA V2. There is no way for an individual to check without creating a PR. |
Still problems: kubernetes/kubernetes#97081 (comment) |
It works! kubernetes/kubernetes#107027 (comment) I permit access and requested acceptance for company CLA for "Nordix". I don't know if anybody did something or if the request/permit was enough. Anyway, I am good. Thanks 👍 |
Hello Everyone, I have this PR on I had indeed initially submitted the PR without the CLA, but I'm 99% sure me/my management have followed the correct steps for my PR to be accepted afterwards (we contribute to CNCF projects regularly so we're used to the process but I cannot completely rule out a mistake on our end) Are there any recommended debugging steps which come to mind which might help identify/fix the issue? |
Hi folks! Please take a look! |
We will close the feedback thread on March 5th, that will have been 1 month post-cut over. 👍 |
+1. Thanks for driving this effort. |
Is there a TL;DR here? What does someone who is getting false CLA failures do? |
@MikeSpreitzer we as a project cannot do much, its pretty much follow the link the EasyCLA bot response to log a ticket with the LF. =/ |
Going to go ahead and close this out. Future issues can be created ad-hoc. /close |
@mrbobbytables: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue will be used to collect feedback and issues encountered by the Community during the EasyCLA rollout.
Please post issues encountered here with as much supporting information as possible (screenshots etc).
/area github-integration
The text was updated successfully, but these errors were encountered: