-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apple M1 support #111
Apple M1 support #111
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Welcome @simonoff! |
Hi @simonoff. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test Thanks for this @simonoff! Can you please sign the CLA so we can get this merged in? |
@rjbez17 I have signed it already. |
/assign @adrianludwin |
@simonoff we are in a transition period moving away from the Linux Foundation CLA -> Easy CLA. However, Easy CLA isn't fully rolled out yet (and wont for a bit yet). If you wouldn't mind signing the linux foundation CLA, it would speed things up. You can follow along with the EasyCLA rollout here: kubernetes/org#3068 |
/check-cla |
hm... i have changed and an email and other things. But still not accepted by CLA. |
Does the email in your git commit match what you signed the CLA with? |
@rjbez17 yes, i have made a force commit. and github user name and email were added there. |
Sorry just looking into this now. I think you may need to add a |
Fixes #113 |
EasyCLA went live over the weekend. Lets hope a retest fixes this. |
/lgtm |
/check-cla |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rjbez17, simonoff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cool thanks! |
Its adding support for Apple M1 in build scripts. Could be that I missed something like a docker build or something like this.