Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple M1 support #111

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Apple M1 support #111

merged 1 commit into from
Feb 7, 2022

Conversation

simonoff
Copy link
Contributor

@simonoff simonoff commented Dec 1, 2021

Its adding support for Apple M1 in build scripts. Could be that I missed something like a docker build or something like this.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 1, 2021

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 1, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @simonoff!

It looks like this is your first PR to kubernetes-sigs/hierarchical-namespaces 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/hierarchical-namespaces has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @simonoff. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 1, 2021
@rjbez17
Copy link
Contributor

rjbez17 commented Dec 20, 2021

/ok-to-test

Thanks for this @simonoff! Can you please sign the CLA so we can get this merged in?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 20, 2021
@simonoff
Copy link
Contributor Author

@rjbez17 I have signed it already.

@rjbez17
Copy link
Contributor

rjbez17 commented Dec 20, 2021

/assign @adrianludwin
/assign @rjbez17

@rjbez17
Copy link
Contributor

rjbez17 commented Dec 20, 2021

@simonoff we are in a transition period moving away from the Linux Foundation CLA -> Easy CLA. However, Easy CLA isn't fully rolled out yet (and wont for a bit yet). If you wouldn't mind signing the linux foundation CLA, it would speed things up.

You can follow along with the EasyCLA rollout here: kubernetes/org#3068

@simonoff
Copy link
Contributor Author

/check-cla

@simonoff
Copy link
Contributor Author

hm... i have changed and an email and other things. But still not accepted by CLA.

@rjbez17
Copy link
Contributor

rjbez17 commented Dec 20, 2021

Does the email in your git commit match what you signed the CLA with?

@simonoff
Copy link
Contributor Author

@rjbez17 yes, i have made a force commit. and github user name and email were added there.

@adrianludwin
Copy link
Contributor

Sorry just looking into this now.

I think you may need to add a Signed-off-by: Name <email> to the commit message. E.g. see 04df75b. See if that works?

@adrianludwin
Copy link
Contributor

Fixes #113

@rjbez17
Copy link
Contributor

rjbez17 commented Feb 7, 2022

EasyCLA went live over the weekend. Lets hope a retest fixes this.

@rjbez17
Copy link
Contributor

rjbez17 commented Feb 7, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2022
@rjbez17
Copy link
Contributor

rjbez17 commented Feb 7, 2022

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 7, 2022
@rjbez17
Copy link
Contributor

rjbez17 commented Feb 7, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rjbez17, simonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1fdc099 into kubernetes-sigs:master Feb 7, 2022
@adrianludwin
Copy link
Contributor

Cool thanks!

@adrianludwin adrianludwin added this to the release-v1.0 milestone Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants