✨ add topology conditions #5732

ykakarap · 2021-11-25T04:27:07Z

What this PR does / why we need it:

This PR adds TopologyReconciled condition to classy-clusters.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

linux-foundation-easycla · 2021-11-25T04:27:10Z

❌ - Yuvaraj Kakaraparthi The commit (21be619) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

ykakarap · 2021-11-25T04:35:52Z

/retest

ykakarap · 2021-11-25T04:44:07Z

/retest

RA489 · 2021-11-25T07:20:44Z

/check-cla

fabriziopandini

@ykakarap thanks for this PR!
If we can manage to nail clean up a little bit the naming of the fields in the upgrade tracker, then the entire PR will benefit from it
PS. I still have to take a look at tests, but I will do this when we sort out ^^

api/v1beta1/condition_consts.go

controllers/topology/conditions.go

controllers/topology/desired_state.go

controllers/topology/cluster_controller.go

fabriziopandini · 2021-11-30T10:11:56Z

/check-cla

fabriziopandini

Thanks for addressing the first round of comments!

controllers/topology/desired_state.go

controllers/topology/conditions.go

controllers/topology/internal/scope/upgradetracker.go

fabriziopandini

Thanks for addressing the first round of comments!

controllers/topology/conditions.go

controllers/topology/desired_state.go

ykakarap · 2021-11-30T18:57:31Z

The PR has the cncf-cla: yes label but the EasyCLA pipeline still is failing. Is this a blocker?

fabriziopandini · 2021-12-01T10:39:55Z

@ykakarap EasyCLA is not blocking yet, but please report your issue following instructions provided in https://groups.google.com/g/kubernetes-dev/c/-mdBNXLYZ_Y/m/Bp7B4W7IAAAJ

fabriziopandini · 2021-12-01T15:10:43Z

/lgtm

ykakarap · 2021-12-01T16:09:27Z

@ykakarap EasyCLA is not blocking yet, but please report your issue following instructions provided in https://groups.google.com/g/kubernetes-dev/c/-mdBNXLYZ_Y/m/Bp7B4W7IAAAJ

I already reported it here. So I guess there is nothing to be done for now. :)

api/v1beta1/condition_consts.go

controllers/topology/conditions.go

controllers/topology/desired_state.go

sbueringer

Great work! Mostly nits from my side

api/v1beta1/condition_consts.go

controllers/topology/internal/scope/upgradetracker.go

controllers/topology/cluster_controller.go

controllers/topology/cluster_controller_test.go

controllers/topology/conditions.go

controllers/topology/conditions_test.go

api/v1beta1/condition_consts.go

controllers/topology/cluster_controller_test.go

sbueringer · 2021-12-03T18:34:38Z

Thx and again great work!

/lgtm

vincepri

/approve

k8s-ci-robot · 2021-12-03T22:02:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vincepri · 2021-12-03T22:05:51Z

Great job @ykakarap !

Thanks for addressing all the comments

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 25, 2021

k8s-ci-robot requested review from enxebre and stmcginnis November 25, 2021 04:27

ykakarap changed the title ~~add topology conditions~~ ✨ add topology conditions Nov 25, 2021

fabriziopandini reviewed Nov 29, 2021

View reviewed changes

ykakarap force-pushed the cluster-topology-conditions-4 branch 2 times, most recently from e48956b to 5a2aa5f Compare November 30, 2021 08:27

fabriziopandini reviewed Nov 30, 2021

View reviewed changes

controllers/topology/conditions.go Outdated Show resolved Hide resolved

ykakarap force-pushed the cluster-topology-conditions-4 branch from 5a2aa5f to 968bf92 Compare November 30, 2021 18:45

ykakarap commented Nov 30, 2021

View reviewed changes

controllers/topology/conditions.go Outdated Show resolved Hide resolved

controllers/topology/desired_state.go Show resolved Hide resolved

k8s-ci-robot assigned fabriziopandini Dec 1, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2021

vincepri reviewed Dec 1, 2021

View reviewed changes

sbueringer reviewed Dec 2, 2021

View reviewed changes

ykakarap force-pushed the cluster-topology-conditions-4 branch from 968bf92 to 0dd8b08 Compare December 2, 2021 23:37

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2021

sbueringer reviewed Dec 3, 2021

View reviewed changes

api/v1beta1/condition_consts.go Outdated Show resolved Hide resolved

controllers/topology/cluster_controller_test.go Outdated Show resolved Hide resolved

ykakarap force-pushed the cluster-topology-conditions-4 branch from 0dd8b08 to 69641bb Compare December 3, 2021 18:08

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2021

add cluster topology conditions

21be619

ykakarap force-pushed the cluster-topology-conditions-4 branch from 69641bb to 21be619 Compare December 3, 2021 18:14

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2021

k8s-ci-robot assigned sbueringer Dec 3, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2021

vincepri approved these changes Dec 3, 2021

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2021

k8s-ci-robot merged commit 0a79c4f into kubernetes-sigs:main Dec 3, 2021

k8s-ci-robot added this to the v1.1 milestone Dec 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ add topology conditions #5732

✨ add topology conditions #5732

ykakarap commented Nov 25, 2021

linux-foundation-easycla bot commented Nov 25, 2021 •

edited

Loading

ykakarap commented Nov 25, 2021

ykakarap commented Nov 25, 2021

RA489 commented Nov 25, 2021

fabriziopandini left a comment

fabriziopandini commented Nov 30, 2021

fabriziopandini left a comment

fabriziopandini left a comment

ykakarap commented Nov 30, 2021

fabriziopandini commented Dec 1, 2021

fabriziopandini commented Dec 1, 2021

ykakarap commented Dec 1, 2021

sbueringer left a comment

sbueringer commented Dec 3, 2021

vincepri left a comment

k8s-ci-robot commented Dec 3, 2021

vincepri commented Dec 3, 2021 •

edited

Loading

✨ add topology conditions #5732

✨ add topology conditions #5732

Conversation

ykakarap commented Nov 25, 2021

linux-foundation-easycla bot commented Nov 25, 2021 • edited Loading

ykakarap commented Nov 25, 2021

ykakarap commented Nov 25, 2021

RA489 commented Nov 25, 2021

fabriziopandini left a comment

Choose a reason for hiding this comment

fabriziopandini commented Nov 30, 2021

fabriziopandini left a comment

Choose a reason for hiding this comment

fabriziopandini left a comment

Choose a reason for hiding this comment

ykakarap commented Nov 30, 2021

fabriziopandini commented Dec 1, 2021

fabriziopandini commented Dec 1, 2021

ykakarap commented Dec 1, 2021

sbueringer left a comment

Choose a reason for hiding this comment

sbueringer commented Dec 3, 2021

vincepri left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Dec 3, 2021

vincepri commented Dec 3, 2021 • edited Loading

linux-foundation-easycla bot commented Nov 25, 2021 •

edited

Loading

vincepri commented Dec 3, 2021 •

edited

Loading