Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Containerd to 1.5.9 #776

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

adisky
Copy link
Contributor

@adisky adisky commented Jan 7, 2022

Signed-off-by: Aditi Sharma [email protected]

What this PR does / why we need it:
There has been two CVE fix from 1.5.7 to 1.5.9
CVE-2021-43816.
CVE-2021-41190

https://github.com/containerd/containerd/releases/tag/v1.5.9
https://github.com/containerd/containerd/releases/tag/v1.5.8

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Additional context
Add any other context for the reviewers

CVE fix CVE-2021-43816

Signed-off-by: Aditi Sharma <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 7, 2022
@linux-foundation-easycla
Copy link

CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

Hi @adisky. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 7, 2022
@k8s-ci-robot k8s-ci-robot requested review from akutz and moshloop January 7, 2022 04:45
@adisky
Copy link
Contributor Author

adisky commented Jan 7, 2022

/cc @endocrimes

@k8s-ci-robot
Copy link
Contributor

@adisky: GitHub didn't allow me to request PR reviews from the following users: endocrimes.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @endocrimes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsturtevant
Copy link
Contributor

Looks like you have the CLA signed but the EasyCLA failed. You can leave a comment in kubernetes/org#3068 to report an issue. Not sure if you will be able to fix it using the link above but you can try it out.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 7, 2022
@codenrhoden
Copy link
Contributor

azure failure is a flake...

FAILED! => {"changed": false, "cmd": ["/usr/bin/pip3", "install", "azure-cli"]

/test pull-azure-vhds

@jsturtevant
Copy link
Contributor

azure failure is a flake...

FAILED! => {"changed": false, "cmd": ["/usr/bin/pip3", "install", "azure-cli"]

/test pull-azure-vhds

this looks similar to something I saw a few weeks ago #766

@jsturtevant
Copy link
Contributor

does look to be the same:

omplete output from command python setup.py egg_info:\n    Traceback (most recent call last):\n      File \"<string>\", line 1, in <module>\n      File \"/tmp/pip-build-grcnu6px/cryptography/setup.py\", line 14, in <module>\n        from setuptools_rust import RustExtension\n    ModuleNotFoundError: No module named 'setuptools_rust'\n    \n            =============================DEBUG ASSISTANCE==========================\n            If you are seeing an error here please try the following to\n            successfully install cryptography:\n    \n            Upgrade to the latest pip and try again. This will fix errors for most\n            users. See: https://pip.pypa.io/en/stable/installing/#upgrading-pip\n            =============================DEBUG ASSISTANCE==========================\n    \n    \n    ----------------------------------------\n\n:stderr: Command \"python setup.py egg_info\" failed with error code 1 in /tmp/pip-build-grcnu6px/cryptography/\n"}�[0m

It was transient, but probably need to look further into it as to why.... I left some notes on the issue #766

@jsturtevant
Copy link
Contributor

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 7, 2022

@adisky: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-ova-all 51e0581 link false /test pull-ova-all

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adisky
Copy link
Contributor Author

adisky commented Jan 11, 2022

Looks like you have the CLA signed but the EasyCLA failed. You can leave a comment in kubernetes/org#3068 to report an issue. Not sure if you will be able to fix it using the link above but you can try it out.

/ok-to-test

I already tried the given link & reported to k/org still have issue :)

@codenrhoden
Copy link
Contributor

checksums look good, Azure test looks good. (broken) OVA test isn't going to pick up anything that the Azure installs won't.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adisky, codenrhoden

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2022
@jsturtevant
Copy link
Contributor

EasyCLA is not blocking right now and the linux foundation cla is signed. https://groups.google.com/g/kubernetes-dev/c/-mdBNXLYZ_Y/m/Bp7B4W7IAAAJ

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8c56dec into kubernetes-sigs:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants