Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws] Need a new AWS account to replace 607362164682 #5194

Closed
8 tasks done
dims opened this issue Apr 28, 2023 · 17 comments
Closed
8 tasks done

[aws] Need a new AWS account to replace 607362164682 #5194

dims opened this issue Apr 28, 2023 · 17 comments
Labels
area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.
Milestone

Comments

@dims
Copy link
Member

dims commented Apr 28, 2023

Folks,

I've been wondering about account 607362164682 and finally tracked it down. Once upon a time @gyuho created this account for some of the AWS
related repositories that needed to run CI jobs.

image

Let's please create a new account from our AWS credits to replace this account.

References:

Query to find instances to fix:

Repositories

@dims
Copy link
Member Author

dims commented Apr 28, 2023

@xmudrii @ameukam - how about k8s_infra_eks_e2e_shared_001 as the name

Since:

@BenTheElder
Copy link
Member

BenTheElder commented Apr 28, 2023

@BenTheElder
Copy link
Member

Or else if not shared boskos, this should probably be N different accounts? so we can better track billing, since it's being used for different subprojects (storage, loadbalancer, etc).

@ameukam
Copy link
Member

ameukam commented Apr 28, 2023

LGTM for the naming pattern.

+1 on moving to a boskos pool.

@xmudrii
Copy link
Member

xmudrii commented Apr 28, 2023

+1 for the naming pattern and moving to a boskos pool if possible.

@dims
Copy link
Member Author

dims commented Apr 28, 2023

+1 to boskos as follow ups (we can do it repo by repo with a follow up umbrella issue)

@nnmin-aws had offered to help

@nckturner
Copy link
Contributor

Once we have the account we will need to determine what resources are missing in order to run the CI jobs (there may be IAM roles, S3 buckets, etc) and we also need a new injectable secret like we have now that prow jobs can add to their spec. I'd be interested to know how that was set up actually, i.e. is it creds for an IAM user? I suppose only @shyamjvs knows :)

@dims
Copy link
Member Author

dims commented Apr 28, 2023

@xmudrii @ameukam @BenTheElder ... so the note from @nckturner precludes us to switch to boskos immediately.

Let's create this account k8s_infra_eks_e2e_shared_001 and get some experience with moving jobs one by one and during the process identify stuff we will need to automate to eventually switch to boskos accounts ... (E_DONT_KNOW_IF_WE_WILL_GET_THERE!)

@torredil
Copy link
Member

We use 607362164682 over at kubernetes-sigs/aws-ebs-csi-driver.

Just a few things we need to take care of here, we'll need to create an S3 bucket k8s-kops-csi-e2e with write access in the new account and access to an ECR repository aws-ebs-csi-driver in us-west-2 to push the images built for testing.

Lets ensure https://github.com/kubernetes-sigs/boskos/tree/master/aws-janitor runs against the new account to cleanup any leaked resources.

@ameukam
Copy link
Member

ameukam commented Jul 27, 2023

@dims @xmudrii can we close this ? is there any follow-up to do ?

@xmudrii
Copy link
Member

xmudrii commented Jul 27, 2023

@ameukam I'm not really sure what's the status of this, @dims might know better

@dims
Copy link
Member Author

dims commented Jul 27, 2023

we still need this. let's create a new one k8s_infra_eks_e2e_shared_001 and replace usage of 607362164682 over time slowly

ameukam added a commit to ameukam/k8s.io that referenced this issue Sep 13, 2023
Related to:
  - kubernetes#5194

Add an AWS account will be used to migrate tests aws form a amazon-owned
account.

Signed-off-by: Arnaud Meukam <[email protected]>
@dims
Copy link
Member Author

dims commented Sep 13, 2023

new account is 209411653980

dims added a commit to dims/test-infra that referenced this issue Sep 15, 2023
@dims
Copy link
Member Author

dims commented Sep 16, 2023

calling it! done!

done-and-done-spongebob

@dims
Copy link
Member Author

dims commented Sep 16, 2023

thanks to everyone who helped with fixing things, reviews and approvals

/close

@k8s-ci-robot
Copy link
Contributor

@dims: Closing this issue.

In response to this:

thanks to everyone who helped with fixing things, reviews and approvals

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ameukam
Copy link
Member

ameukam commented Sep 17, 2023

/sig k8s-infra
/kind cleanup
/milestone v1.29
/area infra/aws

@k8s-ci-robot k8s-ci-robot added the sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. label Sep 17, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 17, 2023
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure labels Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.
Projects
Status: Done
Development

No branches or pull requests

7 participants