Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boskos accounts for EKS build cluster #5185

Merged
merged 1 commit into from
May 3, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Apr 27, 2023

As discussed with @hh and @Riaankl privately, I'm adding 10 AWS accounts to be used by boskos in the EKS build cluster. I'll leave some questions and remarks as comments.

Next steps would be:

  • review this PR
  • someone (e.g. @hh or @ameukam) applies this PR and either
    • give me access to those accounts so that I can create IAM users for boskos
    • create IAM users for boskos and give me credentials for those IAM users

/assign @ameukam @dims @hh @Riaankl

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 27, 2023
@k8s-ci-robot k8s-ci-robot requested review from dims and thockin April 27, 2023 14:56
@k8s-ci-robot k8s-ci-robot added area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Apr 27, 2023
@xmudrii
Copy link
Member Author

xmudrii commented Apr 27, 2023

/hold for discussion

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2023
@dims
Copy link
Member

dims commented Apr 27, 2023

/approve
/lgtm

thanks @xmudrii

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2023
@xmudrii
Copy link
Member Author

xmudrii commented May 3, 2023

Accounts are created
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit e613cc7 into kubernetes:main May 3, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 3, 2023
@hh
Copy link
Member

hh commented May 3, 2023

These accounts are all in the Kubernetes 1Password AWS CI Vault:
image

I've shared 7 day links to them with @xmudrii

I'd like to possibly create more vaults, but I'm not yet familiar enough with 1Password.

@xmudrii xmudrii deleted the eks-aws-boskos branch May 3, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants