Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the legacy AWS owned test account 607362164682 #5858

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Remove the legacy AWS owned test account 607362164682 #5858

merged 1 commit into from
Sep 16, 2023

Conversation

dims
Copy link
Member

@dims dims commented Sep 16, 2023

related to #5194

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 16, 2023
@dims dims requested a review from ameukam September 16, 2023 21:33
@k8s-ci-robot k8s-ci-robot added area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 16, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 16, 2023
@dims
Copy link
Member Author

dims commented Sep 16, 2023

/assign @tzneal @torredil @ameukam

tzneal
tzneal approved these changes Sep 16, 2023
View reviewed changes
Copy link

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2023
upodroid
upodroid approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, tzneal, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b41ac3b into kubernetes:main Sep 16, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 16, 2023
@dims
Copy link
Member Author

dims commented Sep 16, 2023 

davanum@cloudshell:~ (kubernetes-public)$ kubectl delete secret -n test-pods aws-credentials-607362164682
secret "aws-credentials-607362164682" deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@tzneal tzneal tzneal approved these changes

@ameukam ameukam Awaiting requested review from ameukam

@justaugustus justaugustus Awaiting requested review from justaugustus

@listx listx Awaiting requested review from listx

Assignees

@tzneal tzneal

@ameukam ameukam

@upodroid upodroid

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
6 participants
@dims @k8s-ci-robot @tzneal @upodroid @ameukam @torredil