Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch couldbuilds from N1 to E2 Machines #5059

Closed
9 tasks done
BenTheElder opened this issue Mar 30, 2023 · 5 comments
Closed
9 tasks done

Switch couldbuilds from N1 to E2 Machines #5059

BenTheElder opened this issue Mar 30, 2023 · 5 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.

Comments

@BenTheElder
Copy link
Member

BenTheElder commented Mar 30, 2023

EDIT: These are actually priced the same on cloud build only currently. I suspect we should switch anyhow (N1 type is outdated...), but this lowers the priority further.

https://cloud.google.com/build/pricing

Cloud Build continues to offer n1-highcpu-8 and n1-highcpu-32 machine types. They are offered at the same price as e2-highcpu-8 and e2-highcpu-32.


Original Issue:

The E2 machine type should have comparable performance but is newer and cheaper than N1 type. (Cheaper in general, NOT cheaper on cloudbuild, see above)

Many of our existing cloudbuilds for pushing images etc are using N1 type.

We should track these down and help update like kubernetes/ingress-nginx#9813.

This is NOT High priority, but this is simple, low-hanging fruit. Should be a good-first-issue

/good-first-issue
/help-wanted

This search query will locate usage within Kubernetes repos:
https://cs.k8s.io/?q=machineType%3A%20N1_HIGH&i=nope&files=&excludeFiles=&repos=

Currently I see these in:

machineType: N1_ should be replaced with machineType: E2_

I've already updated kind and see also kubernetes/test-infra#29195 (comment)

Reference materials:
https://cloud.google.com/build/docs/build-config-file-schema#options
https://cloud.google.com/build/docs/api/reference/rest/v1/projects.builds#machinetype
https://cloud.google.com/blog/products/compute/google-compute-engine-gets-new-e2-vm-machine-types

/sig k8s-infra
/priority backlog

@k8s-ci-robot
Copy link
Contributor

@BenTheElder:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

The E2 machine type should have comparable performance but is newer and cheaper than N1 type.

Many of our existing cloudbuilds for pushing images etc are using N1 type.

We should track these down and help update like kubernetes/ingress-nginx#9813.

This is NOT High priority, but this is simple, low-hanging fruit. Should be a good-first-issue

/good-first-issue
/help-wanted

This search query will locate usage within Kubernetes repos:
https://cs.k8s.io/?q=machineType%3A%20N1_HIGH&i=nope&files=&excludeFiles=&repos=

Currently I see these in:

  • kubernetes/ingress-nginx tracked in please consider e2 instead of n1 for builds ingress-nginx#9813
  • kubernetes-sigs/security-profiles-operator
  • kubernetes/release
  • kubernetes-sigs / etcdadm
  • kubernetes-sigs/kwok
  • kubernetes-sigs/promo-tools
  • kubernetes-sigs/testgrid-json-exporter
  • kubernetes/autoscaler
  • kubernetes/publishing-bot

machineType: N1_ should be replaced with machineType: E2_

I've already updated kind and see also kubernetes/test-infra#29195 (comment)

Reference materials:
https://cloud.google.com/build/docs/build-config-file-schema#options
https://cloud.google.com/build/docs/api/reference/rest/v1/projects.builds#machinetype
https://cloud.google.com/blog/products/compute/google-compute-engine-gets-new-e2-vm-machine-types

/sig k8s-infra
/priority backlog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 30, 2023
@sarab97
Copy link
Member

sarab97 commented Mar 31, 2023

/assign

@BenTheElder
Copy link
Member Author

kubernetes-sigs/security-profiles-operator has remaining false-positive search results from vendor/ vendored code.

otherwise all repos have PRs open or merged already, updated the checklist. thanks @sarab97

@sarab97
Copy link
Member

sarab97 commented Apr 11, 2023

All PRs are merged. Closing this issue.
/close

@k8s-ci-robot
Copy link
Contributor

@sarab97: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

All PRs are merged. Closing this issue.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.
Projects
None yet
Development

No branches or pull requests

3 participants