Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Switch cloudbuild.yaml to e2 machine type #8428

Merged

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:
n1 machine times are old and e2 are going to be cheaper.

Reference kubernetes/k8s.io#5059

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 30, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @TerryHowe!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @TerryHowe. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 30, 2023
@killianmuldoon
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2023
@killianmuldoon
Copy link
Contributor

If we want to change this we should probably change it in cloudbuild_nightly.yaml too. No real opinions on this change though - from the K8s issue it seems like there's no real benefit - the price seems to be the same for both instance types. This helps with future proofing though so I'm fine to update.

@fabriziopandini
Copy link
Member

+1 to stay in in sync with kk
let's change also cloudbuild_nightly.yaml

@TerryHowe
Copy link
Member Author

+1 to stay in in sync with kk let's change also cloudbuild_nightly.yaml

Done

@killianmuldoon
Copy link
Contributor

Could you squash the commits?

Signed-off-by: Terry Howe <[email protected]>
@TerryHowe TerryHowe force-pushed the switch-to-e2-machine-type branch from 000623c to 564a3b5 Compare March 31, 2023 17:37
@TerryHowe
Copy link
Member Author

Could you squash the commits?

Done

@killianmuldoon
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 712565f3c839c911b0a85b876c1beb32ac0db9af

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 86cf5d6 into kubernetes-sigs:main Apr 3, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Apr 3, 2023
@fabriziopandini
Copy link
Member

/cherry-pick release-1.4

@fabriziopandini
Copy link
Member

/cherry-pick release-1.3

@fabriziopandini
Copy link
Member

/cherry-pick release-1.2

@k8s-infra-cherrypick-robot

@fabriziopandini: new pull request created: #8448

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@fabriziopandini: new pull request created: #8449

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@fabriziopandini: new pull request created: #8450

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor

Do we need cherry-picks for these? I thought these jobs were only run on the main branch?

@sbueringer
Copy link
Member

The nightly build is only run on main. The regular one on main and on tags (pretty sure this is part of our release process).

So I think the cherry-picks made sense.

Did we communicate this to providers? A lot of providers are using cloud-build as well. (Probably all that are using the Kubernetes infrastructure for image publishing/promotion)

@killianmuldoon
Copy link
Contributor

Did we communicate this to providers? A lot of providers are using cloud-build as well. (Probably all that are using the Kubernetes infrastructure for image publishing/promotion)

We didn't communicate this - will add it to the CAPI meeting for this week.

@johannesfrey
Copy link
Contributor

/area ci

@k8s-ci-robot k8s-ci-robot added the area/ci Issues or PRs related to ci label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants