-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched from N1 to E2 machine #2989
Conversation
Welcome @sarab97! |
Hi @sarab97. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
This is weird. There was no code change for this test to fail. |
/test pull-release-integration-test |
Thanks for your PR Can you add the specs difference and the price as well in the PR description? |
@cpanato The referenced issue list the details. |
@sarab97 thank you! |
this fixes #2990 |
@cpanato it worked. After rebase the test now passed. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, sarab97 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Replace existing N1 machine with better E2 machine
Which issue(s) this PR fixes:
Reference kubernetes/k8s.io#5059
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?