Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched from N1 to E2 machine #2989

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

sarab97
Copy link
Member

@sarab97 sarab97 commented Mar 31, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Replace existing N1 machine with better E2 machine

Which issue(s) this PR fixes:

Reference kubernetes/k8s.io#5059

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Mar 31, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @sarab97!

It looks like this is your first PR to kubernetes/release 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/release has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 31, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @sarab97. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 31, 2023
@ameukam
Copy link
Member

ameukam commented Mar 31, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2023
@sarab97
Copy link
Member Author

sarab97 commented Mar 31, 2023

This is weird. There was no code change for this test to fail.

@sarab97
Copy link
Member Author

sarab97 commented Mar 31, 2023

/test pull-release-integration-test

@cpanato
Copy link
Member

cpanato commented Mar 31, 2023

Thanks for your PR

Can you add the specs difference and the price as well in the PR description?

@sarab97
Copy link
Member Author

sarab97 commented Mar 31, 2023

Thanks for your PR

Can you add the specs difference and the price as well in the PR description?

@cpanato The referenced issue list the details.
The pricing isnt much different. But with E2 being more efficient and overall taking less time. The cost can be reduced.
https://cloud.google.com/blog/products/compute/google-compute-engine-gets-new-e2-vm-machine-types

@cpanato
Copy link
Member

cpanato commented Mar 31, 2023

@sarab97 thank you!
i will check why the test is failing it is not related to this change

@cpanato
Copy link
Member

cpanato commented Mar 31, 2023

this fixes #2990
as soon that gets merged please rebase

@sarab97
Copy link
Member Author

sarab97 commented Mar 31, 2023

@cpanato it worked. After rebase the test now passed.

@ameukam
Copy link
Member

ameukam commented Mar 31, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2023
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you
/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, sarab97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit 60c0d09 into kubernetes:master Mar 31, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Mar 31, 2023
@sarab97 sarab97 deleted the machine-change branch April 1, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants