Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speedup builds for core CI images #29195

Merged
merged 1 commit into from
Mar 30, 2023
Merged

speedup builds for core CI images #29195

merged 1 commit into from
Mar 30, 2023

Conversation

BenTheElder
Copy link
Member

a fix was merged for these images an hour ago and images are still not ready

let's give these a bit more oomph

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Mar 30, 2023
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Mar 30, 2023
BenTheElder
BenTheElder commented Mar 30, 2023
View reviewed changes
images/krte/cloudbuild.yaml Outdated
@@ -28,6 +28,8 @@ substitutions:
_CFSSL_VERSION: R1.2
options:
substitution_option: ALLOW_LOOSE
# this is a large and critical CI image, builds are slow on the default 1 core
machineType: N1_HIGHCPU_32
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this takes longer to startup (there's a pre warmed pool of default machines) but is much more powerful

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://cloud.google.com/build/docs/build-config-file-schema#options

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

machineType: Cloud Build provides four high-CPU virtual machine types to run your builds: two machine types with 8 CPUs and two machine types with 32 CPUs. The default machine type is 1 CPU. Requesting a high-CPU virtual machine may increase the startup time of your build. Add the machineType option to request a virtual machine with a higher CPU:

https://cloud.google.com/build/docs/api/reference/rest/v1/projects.builds#machinetype

TODO: N1 vs E2. e2 are a big cheaper and might be a better choice, currently some project builds use n1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubernetes/ingress-nginx#9813 and switched to e2 here

@cici37
Copy link
Contributor

cici37 commented Mar 30, 2023

/lgtm
Thank you! (not sure if it's gonna add pressure on infra budget though :) )

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2023
@cici37
Copy link
Contributor

cici37 commented Mar 30, 2023

/hold in case anyone has concern on the budget. Please feel free to unhold if it is not an concern.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2023
@BenTheElder
Copy link
Member Author

i'm going to switch to e2 type

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2023
@cici37
Copy link
Contributor

cici37 commented Mar 30, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2023
@BenTheElder BenTheElder mentioned this pull request Mar 30, 2023
Closed
@BenTheElder
Copy link
Member Author

BenTheElder commented Mar 30, 2023 •
edited
Loading

/hold cancel
we're paying for the compute duration either way, shouldn't be a big issue.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2023
@BenTheElder BenTheElder mentioned this pull request Mar 30, 2023
Merged
@k8s-ci-robot k8s-ci-robot merged commit 8e9af88 into kubernetes:master Mar 30, 2023
@BenTheElder BenTheElder deleted the faster-ci-images branch March 30, 2023 20:59
@BenTheElder BenTheElder mentioned this pull request Mar 30, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@cici37 cici37

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @k8s-ci-robot @cici37