-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subresource status for vpa #5911
Conversation
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
54a2fb2
to
b648ea1
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any problems but previous 2 times we didn't spot problems in review either.
I'd rather not roll back this for the 3rd time. I think we should run e2e tests before merginig.
/hold |
@wu0407 I'm rebasing onto upstream/master to get some changes needed to run e2e tests needed. |
|
/hold cancel |
Add status field in subresource on crd yaml and add new ClusterRole system:vpa-actor to patch /status subresource. The `metadata.generation` only increase on vpa spec update. Fix e2e test for patch and create vpa
b648ea1
to
1f342ff
Compare
rebase done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
🤞
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbartosik, wu0407 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add status field in subresource on crd yaml and add new ClusterRole system:vpa-actor to patch /status subresource.
The
metadata.generation
only increase on vpa spec update.Fix e2e test for patch and create vpa
What type of PR is this?
/kind bug
/kind failing-test
/kind api-change
What this PR does / why we need it:
Current vpa crd has empty subresource field, that leads to metadata.generation increase on vpa status update.
The controller-runtime has GenerationChangedPredicate to filter out update status event for cr, but it not work for vpa.
This PR add status field in subresource on crd yaml and add new ClusterRole system:vpa-actor to patch /status subresource.
The metadata.generation only increase on vpa spec update.
Which issue(s) this PR fixes:
Fixes #5675
Special notes for your reviewer:
Previous pull request is #5680 #5766 and be revert #5738 #5897, because of e2e test failed #5727.
This PR compare with previous PR #5766, only add
subresources
in v1beta2.https://github.com/kubernetes/autoscaler/compare/master...wu0407:autoscaler:add-status-subresource?expand=1#diff-b2539c9dfcc061e38b1961b5e52a8aed413750d74b71c018a3f6ca7dfc871efaR752-R753
@kwiesmueller @jbartosik
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: