-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vpa CRD not contain status subresource #5675
Labels
Comments
wu0407
added a commit
to wu0407/autoscaler
that referenced
this issue
Apr 13, 2023
Fixed: kubernetes#5675 Signed-off-by: xiaoqing <[email protected]>
wu0407
added a commit
to wu0407/autoscaler
that referenced
this issue
Apr 13, 2023
Fixes: kubernetes#5675 Signed-off-by: xiaoqing <[email protected]>
wu0407
added a commit
to wu0407/autoscaler
that referenced
this issue
Apr 22, 2023
wu0407
added a commit
to wu0407/autoscaler
that referenced
this issue
Apr 26, 2023
Add status field in subresource on crd yaml and add new ClusterRole system:vpa-actor to patch /status subresource. The `metadata.generation` only increase on vpa spec update. Fixes: kubernetes#5675 Signed-off-by: xiaoqing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Which component are you using?:
vertical-pod-autoscaler
What version of the component are you using?:
Component version: 0.13.0
What k8s version are you using (
kubectl version
)?:kubectl version
OutputWhat environment is this in?:
kubernetes 1.23
What did you expect to happen?:
vpa crd has stataus field in subresources, that
metadata.generation
only increase in spec changerelate pr #3606
What happened instead?:
The vpa crd has empty subresources that leads to
metadata.generation
increase on vpa status updateautoscaler/vertical-pod-autoscaler/deploy/vpa-v1-crd-gen.yaml
Line 516 in f173888
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
relate code:
autoscaler/vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go
Lines 39 to 52 in f173888
The text was updated successfully, but these errors were encountered: