Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add subresource status for vpa" #5738

Merged
merged 1 commit into from
May 8, 2023
Merged

Revert "Add subresource status for vpa" #5738

merged 1 commit into from
May 8, 2023

Conversation

jbartosik
Copy link
Collaborator

This reverts commit 8e72470.

What type of PR is this?

/kind bug
/kind failing-test

What this PR does / why we need it:

VPA e2e are failing after #5680. We're merging other PRs so we need to revert this. Otherwise we risk merging other breaking PRs and not noticing.

Which issue(s) this PR fixes:

Fixes #5727

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 8, 2023
@k8s-ci-robot k8s-ci-robot requested a review from kgolab May 8, 2023 13:12
@k8s-ci-robot k8s-ci-robot requested a review from krzysied May 8, 2023 13:12
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2023
@jbartosik
Copy link
Collaborator Author

@mwielgus PTAL

@jbartosik
Copy link
Collaborator Author

@wu0407 FYI

mwielgus
mwielgus approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbartosik, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d3ec0c4 into kubernetes:master May 8, 2023
@jbartosik jbartosik deleted the revert-subresource branch May 10, 2023 09:34
@wu0407 wu0407 mentioned this pull request May 17, 2023
Merged
@wu0407 wu0407 mentioned this pull request Jun 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus approved these changes

@kgolab kgolab Awaiting requested review from kgolab

@krzysied krzysied Awaiting requested review from krzysied

Assignees

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VPA e2e actuation, admission-controller, and updater test suites are failing
3 participants
@jbartosik @k8s-ci-robot @mwielgus