Decouple test and install script #7080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: voelzmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
Thanks @voelzmo for this PR. |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR decouples the way that we provide for installing VPA directly from this repository (via
./hack/vpa-up.sh) from the e2e tests. Currently, both take their payload directly frommaster: this makes sense for e2e tests, as they should continuously make sure that the master is still nice and green, but leads to problems, when we introduce change like new parameters for the components (e.g. #6665) or modify the CRD (e.g. #5911).In those cases,
./hack/vpa-up.shalso gets the new CRDs or Deployment yaml files, which don't work well with the last released versions – because they don't contain the necessary code changes. This leads to problems like #6977 and #5982 (comment)With this PR, we switch to the latest release TAG, so we don't get in new, unreleased changes in the CRDs, yamls, etc. The
./hack/vpa-up.shscript is also used during release validation, therefore we assume that the user knows what they are doing if they have set a custom TAG and just leave the current state of the repo.Which issue(s) this PR fixes:
Fixes #7011
Special notes for your reviewer:
Does this PR introduce a user-facing change?