Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ubuntu 22.04 LTS for Azure #961

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Add Ubuntu 22.04 LTS for Azure #961

merged 1 commit into from
Oct 12, 2022

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Sep 2, 2022

What this PR does / why we need it:

Adds Ubuntu 22.04 LTS build support to Azure.

Which issue(s) this PR fixes:

Refs #960

Additional context:

I've tested this and it builds successfully in our DevOps pipeline, but the resulting images need to be tested in a Kubernetes environment.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2022
@mboersma
Copy link
Contributor Author

mboersma commented Sep 2, 2022

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2022
@mboersma
Copy link
Contributor Author

/hold cancel

I've finally done some local testing with this, by building a Ubuntu 22.04 managed image and provisioning CAPZ clusters. Seems to be working.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2022
@mboersma
Copy link
Contributor Author

@andyzhangx @CecileRobertMichon @jackfrancis please take a look.

jackfrancis
jackfrancis approved these changes Sep 29, 2022
View reviewed changes
Copy link

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2022
@jsturtevant
Copy link
Contributor

/lgtm
looks like it is building successfully

==> Builds finished. The artifacts of successful builds are:
--> vhd-ubuntu-2204: Azure.ResourceManagement.VMImage:

This add three more VMs we build for CI. Do we have a plan to remove some at any point?

andyzhangx
andyzhangx approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
btw, are we also going to support Mariner 2.0 in this repo? thanks.

@CecileRobertMichon
Copy link
Contributor

This add three more VMs we build for CI. Do we have a plan to remove some at any point?

+1, let's remove 18.04?

@mboersma
Copy link
Contributor Author

mboersma commented Sep 30, 2022 •
edited
Loading

At one point we discussed publishing 18.04 images until Ubuntu stops publishing updates, which I think is April 2023. But I have no objection to stopping that earlier if we all agree.

I plan to publish Ubuntu 22.04 images for the most recent k8s patch releases as soon as this merges, and then continue to publish 22.04 going forward.

Also, the images we choose to publish are distinct from the tools in this repo. That is, we don't have to remove make build-azure-vhd-ubuntu-1804 and friends in order to stop publishing those reference images.

@mboersma
Copy link
Contributor Author

are we also going to support Mariner 2.0 in this repo?

That would be excellent. I don't think anyone is working on this currently, though.

@jsturtevant
Copy link
Contributor

Also, the images we choose to publish are distinct from the tools in this repo. That is, we don't have to remove make build-azure-vhd-ubuntu-1804 and friends in order to stop publishing those reference images.

Agreed, in addition we can run CI on a subset as well.

@kkeshavamurthy
Copy link
Member

I vote for keeping Ubuntu 18.04 as it's still being used. Since builds are being run in parallel it should not increase the ci time by too much.
Also we since a few different behaviors between ubuntu 18 & 20. So the ci is useful.

@CecileRobertMichon
Copy link
Contributor

My concern is more $ and subscription quota, each CI job creates a VM for each image type. Right now we have:

vhd-centos-7: SUCCESS
vhd-ubuntu-1804: SUCCESS
vhd-windows-2019: SUCCESS
vhd-ubuntu-2004: SUCCESS
vhd-windows-2022-containerd: SUCCESS
vhd-ubuntu-2204: SUCCESS
vhd-windows-2019-containerd: SUCCESS

and

sig-windows-2019: SUCCESS
sig-centos-7-gen2: SUCCESS
sig-ubuntu-2204: SUCCESS
sig-ubuntu-2004-gen2: SUCCESS
sig-windows-2022-containerd: SUCCESS
sig-centos-7: SUCCESS
sig-flatcar: SUCCESS
sig-ubuntu-1804: SUCCESS
sig-flatcar-gen2: SUCCESS
sig-ubuntu-1804-gen2: SUCCESS
sig-ubuntu-2204-gen2: SUCCESS
sig-windows-2019-containerd: SUCCESS
sig-ubuntu-2004: SUCCESS

So 20 VMs for each PR run, which is a lot. If we could make CI a subset of these or at least make some of them optional and not run by default that would help. Not saying we should remove support for 18.04 right away, just concerned about CI.

@mboersma
Copy link
Contributor Author

I can remove ubuntu-1804 from the azure_targets.sh file, which will remove it from CI and other "everything" targets like build-azure-vhds.

(Could we do this for windows-2019 as well? It's mostly been replaced by the -containerd flavors is my understanding.)

@jsturtevant
Copy link
Contributor

(Could we do this for windows-2019 as well? It's mostly been replaced by the -containerd flavors is my understanding.)

Yes I think so. I believe we stopped running dockershim tests (@jackfrancis to confirm) in capz. Especially now that 1.22 is the latest release which supports containerd in capz

@mboersma mboersma mentioned this pull request Oct 3, 2022
Merged
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2022
@jsturtevant
Copy link
Contributor

related to #994

@CecileRobertMichon
Copy link
Contributor

flatcar failed

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2022
@jsturtevant
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, jackfrancis, jsturtevant, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 06e59a7 into kubernetes-sigs:master Oct 12, 2022
@mboersma mboersma deleted the ubuntu-22.04 branch October 12, 2022 16:54
@mboersma mboersma mentioned this pull request Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@jackfrancis jackfrancis jackfrancis approved these changes

@devigned devigned Awaiting requested review from devigned

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@jsturtevant jsturtevant

@jackfrancis jackfrancis

@andyzhangx andyzhangx

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mboersma @jsturtevant @CecileRobertMichon @kkeshavamurthy @k8s-ci-robot @jackfrancis @andyzhangx