Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ubuntu 22.04 builds for AWS and GCP #994

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

AverageMarcus
Copy link
Member

@AverageMarcus AverageMarcus commented Oct 11, 2022

What this PR does / why we need it:
Adds build targets for Ubuntu 22.04 on AWS and GCP

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Towards #960

Additional context

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @AverageMarcus. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 11, 2022
@jsturtevant
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2022
@AverageMarcus
Copy link
Member Author

/retest

@AverageMarcus
Copy link
Member Author

/retest

@kkeshavamurthy
Copy link
Member

@MarcusNoble
I tried running a 22.04 build on AWS and ran into this issue

==> ubuntu-22.04: Launching a source AWS instance...
==> ubuntu-22.04: Adding tags to source instance
    ubuntu-22.04: Adding tag: "Name": "Packer Builder"
    ubuntu-22.04: Instance ID: i-0b8be6898bed5161d
==> ubuntu-22.04: Waiting for instance (i-0b8be6898bed5161d) to become ready...
==> ubuntu-22.04: Using ssh communicator to connect: 44.198.59.225
==> ubuntu-22.04: Waiting for SSH to become available...
==> ubuntu-22.04: Error waiting for SSH: Packer experienced an authentication error when trying to connect via SSH. This can happen if your username/password are wrong. You may want to double-check your credentials as part of your debugging process. original error: ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain
==> ubuntu-22.04: Terminating the source AWS instance...

Builds work fine with 20.04. So I'm thinking there's some version issues in 22.04? I'm using packer 1.8.4. Did you see similar issues in your testing?

@AverageMarcus
Copy link
Member Author

I did initially. I forget exactly what the fix was. Are you using the latest version of the image-builder container image?

We've been building 22.04 AMIs for a while now, here's the override values we're using for it: https://github.com/giantswarm/capi-image-builder/blob/d97cc5dec3421fd5959a2f64197f0417c937f6d7/helm/capi-image-builder/templates/pipelines/capa.yaml#LL67C17-L67C17

@kkeshavamurthy
Copy link
Member

kkeshavamurthy commented Dec 13, 2022

@AverageMarcus
Sorry for the delayed reply,
I was using packer 1.7.2 before. I upgraded to 1.8.4 and things seem to be progressing.

@kkeshavamurthy
Copy link
Member

Thanks for adding this @AverageMarcus
I'm able to Ubuntu 22.04 AMIs.
Can you pls squash your commits and I'll get this merged.

@AverageMarcus
Copy link
Member Author

@kkeshavamurthy Squashed & rebased :)

@kkeshavamurthy
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AverageMarcus, kkeshavamurthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit fbb0428 into kubernetes-sigs:master Dec 14, 2022
@AverageMarcus AverageMarcus deleted the ubuntu-2204 branch December 15, 2022 06:51
This was referenced Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants