-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Ubuntu 22.04 builds for AWS and GCP #994
Conversation
Hi @AverageMarcus. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
/retest |
@MarcusNoble
Builds work fine with 20.04. So I'm thinking there's some version issues in 22.04? I'm using packer 1.8.4. Did you see similar issues in your testing? |
I did initially. I forget exactly what the fix was. Are you using the latest version of the image-builder container image? We've been building 22.04 AMIs for a while now, here's the override values we're using for it: https://github.com/giantswarm/capi-image-builder/blob/d97cc5dec3421fd5959a2f64197f0417c937f6d7/helm/capi-image-builder/templates/pipelines/capa.yaml#LL67C17-L67C17 |
@AverageMarcus |
Thanks for adding this @AverageMarcus |
Signed-off-by: Marcus Noble <[email protected]>
ac474b3
to
9d84038
Compare
@kkeshavamurthy Squashed & rebased :) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AverageMarcus, kkeshavamurthy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds build targets for Ubuntu 22.04 on AWS and GCP
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Towards #960
Additional context