Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old build targets from Azure test matrix #989

Merged

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Oct 3, 2022

What this PR does / why we need it:

In preparing to add Ubuntu 22.04 support to Azure Cluster API images, we realized that our PR test matrix is huge (up to 20 items, requiring 20 Azure VMs to be provisioned for each CI run). This mostly removes ubuntu-1804 and windows-2019 from that matrix, as they are both on the verge of being sunsetted.

Which issue(s) this PR fixes:

N/A

Additional context

See also #961

cc: @CecileRobertMichon @jackfrancis @jsturtevant @kkeshavamurthy

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 3, 2022
@mboersma
Copy link
Contributor Author

mboersma commented Oct 3, 2022

/test pull-azure-sigs pull-azure-vhds

@mboersma
Copy link
Contributor Author

mboersma commented Oct 3, 2022

/test pull-azure-sigs pull-azure-vhds

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 3, 2022
@mboersma
Copy link
Contributor Author

mboersma commented Oct 3, 2022

/test pull-azure-sigs

@mboersma mboersma force-pushed the shrink-azure-test-matrix branch 2 times, most recently from 2f41cae to ff95362 Compare October 3, 2022 19:29
@mboersma
Copy link
Contributor Author

mboersma commented Oct 3, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2022
@kkeshavamurthy
Copy link
Member

Thanks @mboersma
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2022
@CecileRobertMichon
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2022
@CecileRobertMichon
Copy link
Contributor

/hold

there is an error in CI logs but I'm not sure if it's related to this PR

ERROR: Please run 'az login' to setup account.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2022
@CecileRobertMichon
Copy link
Contributor

/test pull-azure-sigs
/test pull-azure-vhds

@CecileRobertMichon
Copy link
Contributor

there is an error in CI logs but I'm not sure if it's related to this PR

looks related, the same error occurs on re-runs, and it's not present in other PRs running the same job

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2022
@mboersma
Copy link
Contributor Author

mboersma commented Oct 5, 2022

I was trying to define new variables by adding to existing variables in azure_targets.sh to make maintenance easier. But I didn't realize that the Makefile just uses grep on this file, so the variables weren't expanded. I did so manually.

@mboersma
Copy link
Contributor Author

mboersma commented Oct 5, 2022

All passing as expected now, no az login or other errors.

@mboersma
Copy link
Contributor Author

mboersma commented Oct 5, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2022
@mboersma
Copy link
Contributor Author

mboersma commented Oct 5, 2022

/retest pull-azure-sigs

Starting collection install process
Downloading https://galaxy.ansible.com/download/ansible-windows-1.11.1.tar.gz to /root/.ansible/tmp/ansible-local-89fxlxeeam/tmpnc7dwu6h/ansible-windows-1.11.1-kp8rxb7_
ERROR! Unexpected Exception, this is probably a bug: The read operation timed out

@k8s-ci-robot
Copy link
Contributor

@mboersma: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test json-sort-check
  • /test pull-azure-vhds
  • /test pull-goss-populate
  • /test pull-ova-all
  • /test pull-packer-validate

The following commands are available to trigger optional jobs:

  • /test pull-azure-sigs
  • /test pull-container-image-build
  • /test pull-image-builder-gcp-all

Use /test all to run the following jobs that were automatically triggered:

  • pull-azure-sigs
  • pull-azure-vhds

In response to this:

/retest pull-azure-sigs

Starting collection install process
Downloading https://galaxy.ansible.com/download/ansible-windows-1.11.1.tar.gz to /root/.ansible/tmp/ansible-local-89fxlxeeam/tmpnc7dwu6h/ansible-windows-1.11.1-kp8rxb7_
ERROR! Unexpected Exception, this is probably a bug: The read operation timed out

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma
Copy link
Contributor Author

mboersma commented Oct 5, 2022

/test pull-azure-sigs

@mboersma
Copy link
Contributor Author

mboersma commented Oct 5, 2022

/retest

flatcar and centos-7 failed, one for each job. Looks like a flake that this change shouldn't have caused.

@mboersma
Copy link
Contributor Author

mboersma commented Oct 6, 2022

/retest

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3f743a5 into kubernetes-sigs:master Oct 11, 2022
@mboersma mboersma deleted the shrink-azure-test-matrix branch October 11, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants