Add Ubuntu 24.04 LTS for Azure #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
The two targets % PACKER_LOG=1 noproxy=* make -C images/capi build-azure-sig-ubuntu-2404-gen2
hack/ensure-python.sh
Checking if python is available
Python 3.12.3
...
2024/04/26 10:07:34 On error:
A build command cannot run without at least one build to process. If the only or
except flags have been specified at run time check that at least one build is
selected for execution.
Error: No builds to run
A build command cannot run without at least one build to process. If the only or
2024/04/26 10:07:34 [INFO] (telemetry) Finalizing.
except flags have been specified at run time check that at least one build is
selected for execution.
2024/04/26 10:07:34 waiting for all plugin processes to complete...
make: *** [build-azure-sig-ubuntu-2404-gen2] Error 1I'm having trouble figuring out where this is going wrong. The other new targets all work. Any help would be appreciated! Edit: fixed, see below |
mboersma
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
mboersma
force-pushed
the
azure-ubuntu-2404
branch
from
e3c575d
to
79aada0
Compare
mboersma
changed the title
mboersma
added
the
kind/feature
mboersma
force-pushed
the
azure-ubuntu-2404
branch
from
b9a9681
to
210a1d4
Compare
k8s-ci-robot
added
size/M
|
Still getting Edit: never mind, I finally realized the |
mboersma
force-pushed
the
azure-ubuntu-2404
branch
from
210a1d4
to
1c82b4b
Compare
|
/retitle Add Ubuntu 24.04 LTS for Azure |
k8s-ci-robot
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
mboersma
commented
May 3, 2024
| SIG_CVM_TARGETS="ubuntu-2004 ubuntu-2204 windows-2019-containerd windows-2022-containerd" | ||
| SIG_CVM_CI_TARGETS="ubuntu-2204 windows-2022-containerd" | ||
| VHD_TARGETS="ubuntu-2004 ubuntu-2204 ubuntu-2404 centos-7 mariner-2 rhel-8 windows-2019-containerd windows-2022-containerd" | ||
| VHD_CI_TARGETS="ubuntu-2204 ubuntu-2404 mariner-2 windows-2019-containerd windows-2022-containerd" |
There was a problem hiding this comment.
I traded Ubuntu 20.04 for 24.04 in CI, not wanting to expand our costs per PR run. But please let me know if this doesn't seem like a worthwhile tradeoff.
| @@ -488,7 +488,7 @@ $(AZURE_BUILD_SIG_GEN2_TARGETS): deps-azure | |||
|
|
|||
| .PHONY: $(AZURE_BUILD_SIG_CVM_TARGETS) | |||
| $(AZURE_BUILD_SIG_CVM_TARGETS): deps-azure | |||
| . $(abspath packer/azure/scripts/init-sig.sh) $(subst build-azure-sig-,,$@) && packer build $(if $(findstring windows,$@),$(PACKER_WINDOWS_NODE_FLAGS),$(PACKER_NODE_FLAGS)) -var-file="$(abspath packer/azure/azure-config.json)" -var-file="$(abspath packer/azure/azure-sig-cvm.json)" -var-file="$(abspath packer/azure/$(subst build-azure-sig-,,$@).json)" -only="$(subst build-azure-,,$@)" $(ABSOLUTE_PACKER_VAR_FILES) packer/azure/packer$(findstring -windows,$@).json | |||
| . $(abspath packer/azure/scripts/init-sig.sh) $(subst build-azure-sig-,,$@) && $(PACKER) build $(if $(findstring windows,$@),$(PACKER_WINDOWS_NODE_FLAGS),$(PACKER_NODE_FLAGS)) -var-file="$(abspath packer/azure/azure-config.json)" -var-file="$(abspath packer/azure/azure-sig-cvm.json)" -var-file="$(abspath packer/azure/$(subst build-azure-sig-,,$@).json)" -only="$(subst build-azure-,,$@)" $(ABSOLUTE_PACKER_VAR_FILES) packer/azure/packer$(findstring -windows,$@).json | |||
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AverageMarcus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Adds support for Ubuntu 24.04-based builds on Azure.
Related issues
Additional context