Don't install Azure CLI by default

[mboersma]

Change description

The az CLI isn't necessary for Azure images to run, it's more of a troubleshooting or debugging tool, so let's not install it by default. You can still install it by enabling the debug_tools variable, for example:

PACKER_FLAGS="--var 'debug_tools=true'" noproxy=* \
  make -C images/capi build-azure-vhd-mariner-2

Related issues

• Fixes Don't install azure client by default #1330
• Unblocks Add Ubuntu 24.04 LTS for Azure #1454 (since there's no .deb feed for az on Ubuntu 24.04 yet)
• See also add az-cli for capz windows images #1326

Additional context

I wasn't sure how to test conditionally for the azure-cli package in Goss, so I removed it to match the default. If you have an idea how to keep this as a conditional test, please let me know!

Also this doesn't apply to Windows images currently because I wasn't positive that az wasn't actually required there. But maybe I should extend this behavior to Windows images as well? Feedback welcome.

[mboersma]

/cc @jsturtevant

FYI this doesn't apply to Windows currently. Should it?

[jsturtevant]

FYI this doesn't apply to Windows currently. Should it?

What doesn't apply? We do install azure cli on Windows: #1326

[mboersma]

Sorry, I meant that I didn't wire this up to not install on Windows; it still does so by default. Say the word and I'll try to make Windows images have the same default and option.

[mboersma]

Updated to act the same way in Windows.

[jsturtevant]

/lgtm

[jsturtevant]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jsturtevant]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsturtevant]

/hold
for the tests

[mboersma]

/hold cancel