-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add az-cli for capz windows images #1326
add az-cli for capz windows images #1326
Conversation
Welcome @DannyBrito! |
Hi @DannyBrito. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Looks good judging by the output in the Azure windows jobs. (The |
Is this something we want on every image produced or should it be configurable? It sounds like we install it on linux? |
I think we only want it when building images for the Azure provider, and that's how it is for LInux as well AFAICT. (Despite the generic name |
a52b478
to
88b8c6e
Compare
88b8c6e
to
bebac69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @jsturtevant
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsturtevant The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds azure cli install to CAPZ windows images.
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #
Additional context
Add any other context for the reviewers