Update custom-builds.yaml template to UAMI #4141
Conversation
… and az storage blob download Signed-off-by: Jeremy Rickard <[email protected]> Co-authored-by: Danny Brito <[email protected]>
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @DannyBrito. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/M
|
I assume for this to work, we need kubernetes-sigs/image-builder#1326 to merge, and then to build new CAPZ reference images for e2e to test with, right? Edit: nope, this stands on its own and the image-builder PR will eventually simplify it by handling |
|
/release-note-none |
k8s-ci-robot
added
release-note-none
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4141 +/- ##
==========================================
- Coverage 57.83% 57.82% -0.02%
==========================================
Files 187 187
Lines 19195 19195
==========================================
- Hits 11101 11099 -2
- Misses 7466 7468 +2
Partials 628 628 ☔ View full report in Codecov by Sentry. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/retest flake tracked in #4123 |
templates/test/dev/custom-builds/patches/kubeadm-bootstrap-windows-k8s-pr-binaries.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
We don't have a presubmit for this template in CAPZ so I opened kubernetes/test-infra#31045 to add one so we don't regress k/k tests
|
/retest Network connectivity flake AFAICT. |
|
/assign |
|
/test ls |
|
@CecileRobertMichon: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-provider-azure-conformance-custom-builds |
|
/retest looks like the actual cluster build succeeded |
|
/hold @DannyBrito I'm seeing the following error in the custom-builds job cloud-init logs: Seems like something needs to be setup on the prow subscription managed identity |
k8s-ci-robot
added
the
do-not-merge/hold
|
/test pull-cluster-api-provider-azure-conformance-custom-builds |
|
Created kubernetes/test-infra#31106 to add a windows job |
|
@CecileRobertMichon, the ci custom job passed, and control-plane cloud-int logs look like it was able to pull binaries after role assignation to UAMI, and kubelet version is replaced in the nodes with k8s alpha version node-describe.txt |
|
@DannyBrito perfect. Just waiting for a review on the test-infra PR above to add a windows job so we can test this change for windows too. |
|
/test pull-cluster-api-provider-azure-windows-containerd-upstream-custom-builds |
Looks like we may be running into #3673 |
|
Opened #4172 to fix it |
|
Now that kubernetes/test-infra#31126 merged, windows job should be able to run /test pull-cluster-api-provider-azure-windows-custom-builds |
|
@CecileRobertMichon: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-provider-azure-windows--custom-builds |
|
/test pull-cluster-api-provider-azure-windows-custom-builds |
|
/override pull-cluster-api-provider-azure-windows--custom-builds job was renamed to fix typo |
|
@CecileRobertMichon: Overrode contexts on behalf of CecileRobertMichon: pull-cluster-api-provider-azure-windows--custom-builds In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@DannyBrito: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest hoping that was a flake, but let's see... |
|
Windows custom build looks good as well /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 73b50abe3e6144fec4bbc136872da7a5f9f3a8f9
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/cherry-pick release-1.11 |
|
@CecileRobertMichon: new pull request created: #4202 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Update custom-builds.yaml template components to use UAMI and add az cli for binary replacement download to enable AUTH in azure storage account via UAMI.
cc: @jeremyrickard
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: