✨ Support IPAM and runtime extension providers #7288

fabriziopandini · 2022-09-26T18:50:13Z

What this PR does / why we need it:
This PR adds support for IPAM provider and runtime extensions in clusterctl, Tilt, and E2E tests; also test-extension has been reworked to be compliant with the clusterctl contract for providers + the handling of the ConfigMap has been simplified

Which issue(s) this PR fixes:
Fixes #6154

fabriziopandini · 2022-09-26T19:25:02Z

/test pull-cluster-api-e2e-full-main

sbueringer · 2022-09-27T10:16:05Z

/retest
(looks like a flake, although I've never seen that one before)

sbueringer

Overall looks good!

cmd/clusterctl/cmd/delete.go

docs/book/src/clusterctl/provider-contract.md

docs/book/src/developer/tilt.md

test/extension/config/default/rolebinding.yaml

test/framework/clusterctl/client.go

test/framework/clusterctl/e2e_config.go

Tiltfile

test/extension/handlers/lifecycle/handlers.go

sbueringer · 2022-09-27T12:39:18Z

/test pull-cluster-api-e2e-full-main

sbueringer · 2022-09-27T12:55:46Z

Okay probably related:

      <*errors.withStack | 0xc0021c9db8>: {
          error: <*errors.withMessage | 0xc002128f60>{
              cause: <errors.aggregate | len:1, cap:1>[
                  <*errors.fundamental | 0xc0021c9d70>{
                      msg: "provider runtime-extension-test-extension not found in the target cluster",
                      stack: [0x1bba692, 0x1bb0596, 0x1bfc82a, 0x1bfc679, 0x1c05159, 0x1c97748, 0x85936d, 0x470521],
                  },
              ],
              msg: "failed to check providers in target cluster",
          },
          stack: [0x1bb0645, 0x1bfc82a, 0x1bfc679, 0x1c05159, 0x1c97748, 0x85936d, 0x470521],

killianmuldoon · 2022-09-27T14:06:14Z

test/e2e/cluster_upgrade_runtimesdk.go

@@ -129,43 +130,27 @@ func clusterUpgradeWithRuntimeSDKSpec(ctx context.Context, inputGetter func() cl
 	})

 	It("Should create, upgrade and delete a workload cluster", func() {
-		By("Deploy Test Extension")


Where is the test extension deployed after removing this?

test extension is deployed by clusterctl init because it is defined as a provider in the E2E config file

Right - so to test using an existing cluster the test-extension should be deployed before running the test e.g. with tilt. That's why I couldn't get it working 🙂

fabriziopandini · 2022-09-28T12:07:19Z

/test pull-cluster-api-e2e-full-main

fabriziopandini · 2022-09-28T15:25:30Z

/test pull-cluster-api-e2e-full-main

fabriziopandini · 2022-09-28T16:52:25Z

/test

k8s-ci-robot · 2022-09-28T16:52:26Z

@fabriziopandini: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test pull-cluster-api-build-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-test-main
/test pull-cluster-api-test-mink8s-main
/test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-main
/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-informing-ipv6-main
/test pull-cluster-api-e2e-informing-main
/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-main
pull-cluster-api-build-main
pull-cluster-api-e2e-informing-ipv6-main
pull-cluster-api-e2e-informing-main
pull-cluster-api-e2e-main
pull-cluster-api-test-main
pull-cluster-api-test-mink8s-main
pull-cluster-api-verify-main

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fabriziopandini · 2022-09-28T16:52:40Z

/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main

fabriziopandini · 2022-09-29T10:00:05Z

@sbueringer @killianmuldoon all the E2E tests are good, PTAL

bootstrap/kubeadm/config/default/manager_image_patch.yaml

test/framework/clusterctl/repository.go

fabriziopandini · 2022-09-30T13:02:31Z

/test pull-cluster-api-test-full-main

k8s-ci-robot · 2022-09-30T13:02:33Z

@fabriziopandini: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cluster-api-build-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-test-main
/test pull-cluster-api-test-mink8s-main
/test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-main
/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-informing-ipv6-main
/test pull-cluster-api-e2e-informing-main
/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-main
pull-cluster-api-build-main
pull-cluster-api-e2e-informing-ipv6-main
pull-cluster-api-e2e-informing-main
pull-cluster-api-e2e-main
pull-cluster-api-test-main
pull-cluster-api-test-mink8s-main
pull-cluster-api-verify-main

In response to this:

/test pull-cluster-api-test-full-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fabriziopandini · 2022-09-30T13:49:49Z

/test pull-cluster-api-e2e-full-main

sbueringer · 2022-09-30T14:59:20Z

Great work!

/lgtm

fabriziopandini · 2022-10-01T14:04:24Z

/test pull-cluster-api-e2e-full-main

fabriziopandini · 2022-10-01T14:26:20Z

rebased
renamed the flag from --extension to --runtime-extension (more specific)

sbueringer · 2022-10-04T14:34:31Z

/lgtm

ykakarap

/lgtm

fabriziopandini · 2022-10-05T11:04:23Z

removed shortcut from --runtime-extension flag

fabriziopandini · 2022-10-05T11:05:16Z

/test pull-cluster-api-e2e-full-main

sbueringer · 2022-10-05T11:07:44Z

/lgtm

killianmuldoon · 2022-10-05T11:45:55Z

/lgtm

sbueringer · 2022-10-05T12:09:31Z

/approve

e2e-full is green

Great work 🎉

k8s-ci-robot · 2022-10-05T12:09:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sbueringer · 2022-10-05T12:09:49Z

cc @schrej :)

fabriziopandini requested review from sbueringer and killianmuldoon September 26, 2022 18:50

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 26, 2022

k8s-ci-robot requested review from CecileRobertMichon and JoelSpeed September 26, 2022 18:50

sbueringer reviewed Sep 27, 2022

View reviewed changes

killianmuldoon reviewed Sep 27, 2022

View reviewed changes

sbueringer reviewed Sep 29, 2022

View reviewed changes

bootstrap/kubeadm/config/default/manager_image_patch.yaml Outdated Show resolved Hide resolved

test/framework/clusterctl/repository.go Outdated Show resolved Hide resolved

test/framework/clusterctl/repository.go Outdated Show resolved Hide resolved

killianmuldoon mentioned this pull request Sep 29, 2022

[WIP] 📖 Add initial guide to deploying addons with tilt #7154

Closed

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2022

This was referenced Sep 30, 2022

Drop test/e2e/Makefile #7320

Closed

Ideas for test extensions improvements #7322

Closed

fabriziopandini force-pushed the support-ipam-and-runtime-extension-providers branch from ebd86eb to 6881c75 Compare September 30, 2022 13:01

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2022

fabriziopandini force-pushed the support-ipam-and-runtime-extension-providers branch from 6881c75 to 64d8866 Compare September 30, 2022 13:34

fabriziopandini force-pushed the support-ipam-and-runtime-extension-providers branch from 916e9ea to 09e290f Compare October 1, 2022 13:59

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2022

ykakarap approved these changes Oct 5, 2022

View reviewed changes

k8s-ci-robot assigned ykakarap Oct 5, 2022

sbueringer mentioned this pull request Oct 5, 2022

🌱 Remove test/e2e/Makefile and move targets to root Makefile #7329

Merged

fabriziopandini added 3 commits October 5, 2022 13:01

add support for IPAM and Runtime Extension provider in clusterctl

aacbbc7

add support for IPAM and Runtime Extension provider in tilt

5101f01

add support for IPAM and Runtime Extension provider in E2E

2fb12b1

fabriziopandini force-pushed the support-ipam-and-runtime-extension-providers branch from 09e290f to 2fb12b1 Compare October 5, 2022 11:03

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2022

k8s-ci-robot assigned killianmuldoon Oct 5, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2022

k8s-ci-robot merged commit 82f4792 into kubernetes-sigs:main Oct 5, 2022

k8s-ci-robot added this to the v1.3 milestone Oct 5, 2022

fabriziopandini deleted the support-ipam-and-runtime-extension-providers branch October 10, 2022 15:41

christianang mentioned this pull request Oct 20, 2022

Add clusterctl support kubernetes-sigs/cluster-api-ipam-provider-in-cluster#33

Closed

tylerschultz mentioned this pull request Oct 25, 2022

[WIP] ✨ E2E for IPAM support kubernetes-sigs/cluster-api-provider-vsphere#1667

Closed

Jont828 mentioned this pull request Apr 4, 2023

✨ Add support for add-on providers in clusterctl #8472

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Support IPAM and runtime extension providers #7288

✨ Support IPAM and runtime extension providers #7288

fabriziopandini commented Sep 26, 2022

fabriziopandini commented Sep 26, 2022

sbueringer commented Sep 27, 2022

sbueringer left a comment

sbueringer commented Sep 27, 2022

sbueringer commented Sep 27, 2022

killianmuldoon Sep 27, 2022

fabriziopandini Sep 27, 2022

killianmuldoon Sep 27, 2022

fabriziopandini commented Sep 28, 2022

fabriziopandini commented Sep 28, 2022

fabriziopandini commented Sep 28, 2022

k8s-ci-robot commented Sep 28, 2022

fabriziopandini commented Sep 28, 2022

fabriziopandini commented Sep 29, 2022

fabriziopandini commented Sep 30, 2022

k8s-ci-robot commented Sep 30, 2022

fabriziopandini commented Sep 30, 2022

sbueringer commented Sep 30, 2022 •

edited

Loading

fabriziopandini commented Oct 1, 2022

fabriziopandini commented Oct 1, 2022

sbueringer commented Oct 4, 2022

ykakarap left a comment

fabriziopandini commented Oct 5, 2022 •

edited

Loading

fabriziopandini commented Oct 5, 2022

sbueringer commented Oct 5, 2022

killianmuldoon commented Oct 5, 2022

sbueringer commented Oct 5, 2022

k8s-ci-robot commented Oct 5, 2022

sbueringer commented Oct 5, 2022

✨ Support IPAM and runtime extension providers #7288

✨ Support IPAM and runtime extension providers #7288

Conversation

fabriziopandini commented Sep 26, 2022

fabriziopandini commented Sep 26, 2022

sbueringer commented Sep 27, 2022

sbueringer left a comment

Choose a reason for hiding this comment

sbueringer commented Sep 27, 2022

sbueringer commented Sep 27, 2022

killianmuldoon Sep 27, 2022

Choose a reason for hiding this comment

fabriziopandini Sep 27, 2022

Choose a reason for hiding this comment

killianmuldoon Sep 27, 2022

Choose a reason for hiding this comment

fabriziopandini commented Sep 28, 2022

fabriziopandini commented Sep 28, 2022

fabriziopandini commented Sep 28, 2022

k8s-ci-robot commented Sep 28, 2022

fabriziopandini commented Sep 28, 2022

fabriziopandini commented Sep 29, 2022

fabriziopandini commented Sep 30, 2022

k8s-ci-robot commented Sep 30, 2022

fabriziopandini commented Sep 30, 2022

sbueringer commented Sep 30, 2022 • edited Loading

fabriziopandini commented Oct 1, 2022

fabriziopandini commented Oct 1, 2022

sbueringer commented Oct 4, 2022

ykakarap left a comment

Choose a reason for hiding this comment

fabriziopandini commented Oct 5, 2022 • edited Loading

fabriziopandini commented Oct 5, 2022

sbueringer commented Oct 5, 2022

killianmuldoon commented Oct 5, 2022

sbueringer commented Oct 5, 2022

k8s-ci-robot commented Oct 5, 2022

sbueringer commented Oct 5, 2022

sbueringer commented Sep 30, 2022 •

edited

Loading

fabriziopandini commented Oct 5, 2022 •

edited

Loading