Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove test/e2e/Makefile and move targets to root Makefile #7329

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

oscr
Copy link
Contributor

@oscr oscr commented Sep 30, 2022

What this PR does / why we need it:
Removes test/e2e/Makefile and moves targets to the root Makefile.

The root Makefile now has the following last section:

end-to-end
  cluster-templates                              Generate cluster templates for all versions
  cluster-templates-v1alpha3                     Generate cluster templates for v1alpha3
  cluster-templates-v1alpha4                     Generate cluster templates for v1alpha4
  cluster-templates-v1beta1                      Generate cluster templates for v1beta1
  test-extension-deployment                      Generate deployment for test extension
  run                                            Run the end-to-end tests

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #7320

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2022
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oscr thanks for jumping on this one

docs/book/src/developer/testing.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@oscr oscr force-pushed the remove-e2e-makefile branch from d13ac43 to 98464c0 Compare October 3, 2022 10:08
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@oscr oscr force-pushed the remove-e2e-makefile branch from 98464c0 to af01a42 Compare October 4, 2022 14:01
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work
/lgtm

@sbueringer PTAL when you have some time

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2022
@oscr
Copy link
Contributor Author

oscr commented Oct 4, 2022

Thank you for all your feedback and help @fabriziopandini 🙏

@sbueringer
Copy link
Member

I'll take a look soon, probably tomorrow

Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just nits

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

Can we merge #7288 before #7329? I think #7329 is easier to rebase

@oscr
Copy link
Contributor Author

oscr commented Oct 5, 2022

Can we merge #7288 before #7329? I think #7329 is easier to rebase

Sure, that's no issue for me. I can rebase the pr as soon as #7288 merges.

@oscr oscr force-pushed the remove-e2e-makefile branch from af01a42 to 351b6a0 Compare October 5, 2022 13:05
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2022
@oscr oscr force-pushed the remove-e2e-makefile branch from 351b6a0 to c8230a7 Compare October 5, 2022 13:20
@oscr
Copy link
Contributor Author

oscr commented Oct 5, 2022

/retest

@sbueringer
Copy link
Member

sbueringer commented Oct 5, 2022

/test pull-cluster-api-e2e-full-main

/lgtm

EDIT: I think Prow has some problems right now. If it doesn't re-act let's wait a bit or retest tomorrow

@oscr
Copy link
Contributor Author

oscr commented Oct 5, 2022

Yes, Prow seems really slow to trigger today.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2022
@fabriziopandini
Copy link
Member

#7288 is merged
/lgtm

@sbueringer for final approval

@fabriziopandini
Copy link
Member

(oops it is already there)
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1a71841 into kubernetes-sigs:main Oct 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop test/e2e/Makefile
4 participants