-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Remove test/e2e/Makefile and move targets to root Makefile #7329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oscr thanks for jumping on this one
d13ac43
to
98464c0
Compare
98464c0
to
af01a42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work
/lgtm
@sbueringer PTAL when you have some time
Thank you for all your feedback and help @fabriziopandini 🙏 |
I'll take a look soon, probably tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just nits
af01a42
to
351b6a0
Compare
351b6a0
to
c8230a7
Compare
/retest |
/test pull-cluster-api-e2e-full-main /lgtm EDIT: I think Prow has some problems right now. If it doesn't re-act let's wait a bit or retest tomorrow |
Yes, Prow seems really slow to trigger today. |
#7288 is merged @sbueringer for final approval |
(oops it is already there) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Removes
test/e2e/Makefile
and moves targets to the root Makefile.The root Makefile now has the following last section:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #7320