-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] 📖 Add initial guide to deploying addons with tilt #7154
[WIP] 📖 Add initial guide to deploying addons with tilt #7154
Conversation
Signed-off-by: killianmuldoon <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@killianmuldoon I’m wondering if we should move away from using addon, which is an overloaded term, and use resource instead, which is the term used by tilt or be explicit and use extensions, which is the use case we care about. |
Sounds good to me. Given that the implementation doesn't really care about what it's deploying maybe something more generic like "deployment" would be slightly better than "extension". I think resource doesn't fit (as we're building & deploying way more than just a single resource) |
@@ -378,6 +378,55 @@ Set to `false` if your provider does not have a ./config folder or you do not wa | |||
in tilt version >= v0.22.2 (see https://blog.tilt.dev/2021/08/09/resource-grouping.html); as a convention, | |||
provider abbreviation should be used (CAPD, KCP etc.). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(unrelated to this file just had to add it somewhere)
We're adding a Tips & Tricks section to the implementation doc in #7270.
There was a suggestion to also mention the tilt setup there:
What if we add a note about being possible to develop and test with tilt (assuming that #7154 merge soon, this note could close the circle)
#7270 (comment)
/close This needs a complete rewrite as the dev process will change in #7288 |
@killianmuldoon: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: killianmuldoon [email protected]
Add information to the book about how users can deploy addons with tilt, and how to develop Runtime Extensions using the tilt environment.