[WIP] ✨ E2E for IPAM support

[tylerschultz]

What this PR does / why we need it:

This PR adds an E2E test for IPAM support. The test asserts that VMs are assigned IP addresses from an IPAM provider pool.

This PR is based on a branch from another PR, which needs to merge first.
#1666

This PR makes no attempt to integrate the e2e test into this repo's CI.

The test adds and requires the following variables:
- NODE_IPAM_POOL_SUBNET
- NODE_IPAM_POOL_GATEWAY
- NODE_IPAM_POOL_START
- NODE_IPAM_POOL_END
- NODE_IPAM_NAMESERVER

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
Do not merge this PR before merging #1666.

This PR requires a new release CAPI. main of CAPI contains changes required for testing IPAM, specifically the --ipam-provider flag on clusterctl. This functionality was added in this PR: kubernetes-sigs/cluster-api#7288 (this PR may now be released?) main of CAPI has recently switched to Ginkgo v2, requiring CAPV switch too, due to the many test utilities pulled in from CAPI.

In it's current from, this PR depends on the telekom CAPI IPAM Provider In Cluster project.

Loose ends:

• vsphere-dev.yaml contains NODE_IPAM_* configurations specific to our environment. How can this be generified?
• CI configuration:
  • each run will need a block of IPs that it can use to test IPAM

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval by writing /assign @vincepri in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @tylerschultz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[christianang]

There is now a release of the in cluster ipam provider we can use: https://github.com/telekom/cluster-api-ipam-provider-in-cluster/releases/tag/v0.1.0-alpha.1

From previous conversations during office hours we will want to wait for cluster-api to make a release with the --ipam flag in clusterctl that we can depend on in this PR.

[srm09]

Waiting for the CAPI 1.3.0 to be released which should be sometime this week, post which we can update the CAPI version in main and get on with this PR

[schrej]

Friendly reminder that 1.3.0 (actually .1) is released now, which contains the required support for IPAM providers :)

[tylerschultz]

Hi @schrej,
Thanks for the reminder. Sorry for the delay - holidays/vacation time, other priorities, etc.
We're coordinating a little behind the scenes with @srm09 to get the infra details sorted.
This is still on our radar, and we intend to follow through.

[srm09]

The PR to update CAPV testing infra to use CAPI 1.3.0 was merged yesterday. We will need some more work to be done on the infra side to make this run. Namely create a pool to be used by this IPAM test.

[christianang]

We rebased the PR on main. Let us know if you want/or we can help with anything in setting up CI, but for now I'll assume you have that covered.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[sbueringer]

@tylerschultz Can you get us to speed what the current state of this PR is? Thank you!

[adobley]

@srm09 Do you know if a pool was created to run these tests against? That should be the last piece we were waiting on.

[randomvariable]

@srm09 is working on a doc, we need a mechanism to pool IPPools themselves so we can have concurrent testing, but we may need to wait a bit until maintainers have a better overview of the test infrastructure. Hoping to make progress in next 2 weeks.

[chrischdi]

We need to take a look in some future to outline a plan and work on this.

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.