Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E test to verify workload cluster upgrades #4043

Closed
srm09 opened this issue Jan 4, 2021 · 13 comments · Fixed by #4130 or kubernetes/test-infra#20720
Closed

Add E2E test to verify workload cluster upgrades #4043

srm09 opened this issue Jan 4, 2021 · 13 comments · Fixed by #4130 or kubernetes/test-infra#20720
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@srm09
Copy link
Contributor

srm09 commented Jan 4, 2021

User Story

As a developer, I would like to run an E2E test to verify upgrading CAPI workload cluster between 2 supported versions.

Detailed Description

  • A new prow job should be run periodically which runs the entire upgrade matrix for workload clusters.
  • As for the actual test, we carry out the following steps
    • Create a workload cluster with version, say v.1.17
    • Upgrade the workload cluster to version, say v1.18
    • Run conformance tests on the upgraded cluster to verify the normal working of the cluster post upgrade.
    • As @fabriziopandini commented below, upgrade refers to upgrading the CP, MachinePool and MachineDeployment worker nodes.

Anything else you would like to add:

For the complete discussion on the introduction of these tests, look at #3693 (comment) .
TL;DR We need to add E2E tests to verify the upgrades between supported k8s versions.

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 4, 2021
@srm09
Copy link
Contributor Author

srm09 commented Jan 4, 2021

/assign
Waiting for the PRs #3916 and #4042 to get merged.
cc: @fabriziopandini

@vincepri
Copy link
Member

vincepri commented Jan 4, 2021

Any reason we've picked these two specific Kubernetes versions?

@vincepri
Copy link
Member

vincepri commented Jan 4, 2021

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Jan 4, 2021
@detiber
Copy link
Member

detiber commented Jan 4, 2021

Any reason we've picked these two specific Kubernetes versions?

+1, While I think it makes sense to have something as the defaults, I would like to see something that is more easily configured at runtime that would allow for automating prow jobs more easily.

@srm09
Copy link
Contributor Author

srm09 commented Jan 4, 2021

The idea was to start with a single job which tests one of the upgrade paths mentioned in the #3693 (comment). Once that gets done, we raise new issues for all the other upgrade tests required and ask some help from the community to finish those off.

I would like to see something that is more easily configured at runtime that would allow for automating prow jobs more easily.

That is the end goal, to keep the test/job configurable enough to introduce more upgrade paths easily.

@fabriziopandini
Copy link
Member

As a reminder, upgrade in this context should include upgrading the control plane and the workers (including machines controlled by MachineDeployments and machines controlled by MachinePools)

@fabriziopandini
Copy link
Member

#3916 merged, so now this activity is unblocked
/help

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

#3916 merged, so now this activity is unblocked
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 19, 2021
@srm09
Copy link
Contributor Author

srm09 commented Feb 3, 2021

Updating this story to include the entire test matrix for workload cluster upgrade testing.

@srm09
Copy link
Contributor Author

srm09 commented Feb 3, 2021

/retitle Add E2E test to verify workload cluster upgrades

@k8s-ci-robot k8s-ci-robot changed the title Add an E2E test to verify workload cluster upgrades between v1.17 and v1.18 Add E2E test to verify workload cluster upgrades Feb 3, 2021
@fabriziopandini
Copy link
Member

/lifecycle active
/priority important-soon

@k8s-ci-robot k8s-ci-robot added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 10, 2021
@vincepri
Copy link
Member

Is this being worked on?

@fabriziopandini
Copy link
Member

fabriziopandini commented Mar 10, 2021

yes
There are PR both in CAPI and test infra ready to merge (I pinged recently in slack you and @CecileRobertMichon)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
5 participants