🌱 E2E test to upgrade workload cluster #4130

srm09 · 2021-01-28T23:36:02Z

What this PR does / why we need it:
Adds a new E2E test to upgrade a workload cluster and run conformance tests to verify the upgrade

Which issue(s) this PR fixes:
Fixes #4043

srm09 · 2021-01-28T23:40:24Z

/hold WIP

neolit123

thanks for the PR, added some quick comments on styling / wording.

test/e2e/cluster_upgrade.go

test/e2e/cluster_upgrade_test.go

test/e2e/cluster_upgrade.go

srm09 · 2021-02-01T18:51:21Z

/test pull-cluster-api-e2e-full-main

srm09 · 2021-02-01T19:31:16Z

/test pull-cluster-api-e2e-full-main

srm09 · 2021-02-01T21:20:34Z

cc @fabriziopandini PTAL, working on a prow job to run this with different combinations of versions.

vincepri · 2021-02-03T17:49:04Z

/assign @fabriziopandini

test/e2e/Makefile

fabriziopandini · 2021-02-04T15:54:04Z

test/e2e/cluster_upgrade_test.go

+	. "github.com/onsi/ginkgo"
+)
+
+var _ = Describe("When upgrading a workload cluster and testing K8S conformance [K8SVersion-Upgrade]", func() {


I would suggest to document labels ([K8SVersion-Upgrade]) in https://cluster-api.sigs.k8s.io/developer/testing.html#running-the-end-to-end-tests and cross link the list of labels in https://cluster-api.sigs.k8s.io/developer/e2e.html

Also, are you planning to sunset the [Periodic-K8SVersion] label?

wfernandes

I'm a +1 on @fabriziopandini's suggestions regarding documenting the test labels and perhaps reusing [Periodic-K8SVersion] if it follows the intent.

@srm09 Is there a reason we still have the /hold on this?

test/e2e/config/docker.yaml

.../data/infrastructure-docker/v1alpha4/cluster-template-md-and-machine-pool/kustomization.yaml

srm09 · 2021-02-05T00:59:17Z

/unhold

docs/book/src/developer/testing.md

wfernandes

I'm assuming there's a corresponding test-infra PR that updates our CI config so that tests are run without disruption. If there is one, can we link it here 🙂

test/e2e/machine_pool_test.go

fabriziopandini · 2021-02-08T10:49:50Z

/lgtm
@srm09 thanks for driving this effort!
NB. let's make sure to merge this and kubernetes/test-infra#20720 ~at the same time to not block PRs or periodic jobs

srm09 · 2021-02-24T20:25:38Z

/test pull-cluster-api-e2e-full-main

srm09 · 2021-02-24T22:50:09Z

/test pull-cluster-api-test-main
/test pull-cluster-api-e2e-full-main

fabriziopandini · 2021-02-25T11:12:10Z

/retest

srm09 · 2021-03-01T04:36:59Z

/test pull-cluster-api-e2e-full-main

srm09 · 2021-03-02T22:05:20Z

@fabriziopandini Am unsure as to why this is failing. I have had a clean re-run for this locally multiple times.

vincepri · 2021-03-02T23:03:54Z

/retest

fabriziopandini · 2021-03-04T10:37:14Z

/test pull-cluster-api-verify

fabriziopandini · 2021-03-04T10:51:00Z

@srm09 given the type of error in make verify my assumption is that you are using an older version of go locally.
Please update to go 1.16, run make modules, then you should be ok

fabriziopandini · 2021-03-05T19:30:08Z

/milestone v0.4.0

srm09 · 2021-03-08T18:44:37Z

/test pull-cluster-api-e2e-full-main

fabriziopandini · 2021-03-08T20:20:47Z

/lgtm
@srm09 I'm ok to move forward with this. Could you kindly squash commits in kubernetes/test-infra#20720 so we can get the two PR merge ~at the same time?

srm09 · 2021-03-08T20:41:16Z

@fabriziopandini Done

This patch adds an E2E test to create a workload cluster containing of machinedeployment and machinepool. This cluster is then upgraded to another k8s version, including the CP, machine pool and machine deployment. To verify the status of the upgrade, conformance tests are run on the cluster post upgrade. This also updates the e2e run target to include an additional parameter named GINKGO_SKIP which can be used to skip ginkgo tests matching the regexp. Signed-off-by: Sagar Muchhal <[email protected]> Co-authored-by: Cecile Robert-Michon <[email protected]> Co-authored-by: Lubomir I. Ivanov <[email protected]> Co-authored-by: Fabrizio Pandini <[email protected]>

k8s-ci-robot · 2021-03-24T18:23:55Z

@srm09: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-cluster-api-e2e-full-main	`08b3b8b`	link	`/test pull-cluster-api-e2e-full-main`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

srm09 · 2021-03-24T18:32:03Z

/test pull-cluster-api-test-main

fabriziopandini · 2021-03-24T19:53:09Z

/lgtm

fabriziopandini · 2021-03-24T20:04:22Z

/approve

k8s-ci-robot · 2021-03-24T20:04:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 28, 2021

k8s-ci-robot requested review from detiber and vincepri January 28, 2021 23:36

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 28, 2021

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2021

neolit123 reviewed Jan 28, 2021

View reviewed changes

CecileRobertMichon reviewed Jan 28, 2021

View reviewed changes

test/e2e/cluster_upgrade.go Show resolved Hide resolved

CecileRobertMichon reviewed Jan 28, 2021

View reviewed changes

test/e2e/cluster_upgrade.go Outdated Show resolved Hide resolved

srm09 force-pushed the e2e-test-for-upgrades branch from 700c7c6 to 6d949b7 Compare February 1, 2021 19:13

k8s-ci-robot assigned fabriziopandini Feb 3, 2021

fabriziopandini mentioned this pull request Feb 4, 2021

Adds periodic job to test CAPI workload cluster upgrades kubernetes/test-infra#20720

Merged

fabriziopandini reviewed Feb 4, 2021

View reviewed changes

wfernandes reviewed Feb 4, 2021

View reviewed changes

test/e2e/config/docker.yaml Outdated Show resolved Hide resolved

.../data/infrastructure-docker/v1alpha4/cluster-template-md-and-machine-pool/kustomization.yaml Outdated Show resolved Hide resolved

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2021

fabriziopandini reviewed Feb 5, 2021

View reviewed changes

docs/book/src/developer/testing.md Outdated Show resolved Hide resolved

wfernandes reviewed Feb 5, 2021

View reviewed changes

test/e2e/machine_pool_test.go Outdated Show resolved Hide resolved

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2021

srm09 force-pushed the e2e-test-for-upgrades branch from d104154 to ce5715e Compare February 5, 2021 22:55

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2021

srm09 force-pushed the e2e-test-for-upgrades branch 3 times, most recently from cde84d2 to 6a2854c Compare February 5, 2021 23:29

srm09 force-pushed the e2e-test-for-upgrades branch from 176ca24 to 9344d40 Compare February 26, 2021 19:51

srm09 force-pushed the e2e-test-for-upgrades branch from 9344d40 to 43d46f5 Compare March 2, 2021 22:18

srm09 force-pushed the e2e-test-for-upgrades branch from 43d46f5 to ef5fed9 Compare March 4, 2021 18:53

k8s-ci-robot added this to the v0.4.0 milestone Mar 5, 2021

srm09 force-pushed the e2e-test-for-upgrades branch from ef5fed9 to 08b3b8b Compare March 8, 2021 18:30

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2021

srm09 force-pushed the e2e-test-for-upgrades branch from 08b3b8b to 3f7430d Compare March 24, 2021 18:17

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2021

k8s-ci-robot merged commit 1671cbf into kubernetes-sigs:master Mar 24, 2021

srm09 deleted the e2e-test-for-upgrades branch March 24, 2021 20:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🌱 E2E test to upgrade workload cluster #4130

🌱 E2E test to upgrade workload cluster #4130

srm09 commented Jan 28, 2021 •

edited

Loading

srm09 commented Jan 28, 2021

neolit123 left a comment •

edited

Loading

srm09 commented Feb 1, 2021

srm09 commented Feb 1, 2021

srm09 commented Feb 1, 2021

vincepri commented Feb 3, 2021

fabriziopandini Feb 4, 2021

srm09 Feb 5, 2021

wfernandes left a comment

srm09 commented Feb 5, 2021

wfernandes left a comment

fabriziopandini commented Feb 8, 2021

srm09 commented Feb 24, 2021

srm09 commented Feb 24, 2021

fabriziopandini commented Feb 25, 2021

srm09 commented Mar 1, 2021

srm09 commented Mar 2, 2021

vincepri commented Mar 2, 2021

fabriziopandini commented Mar 4, 2021

fabriziopandini commented Mar 4, 2021

fabriziopandini commented Mar 5, 2021

srm09 commented Mar 8, 2021

fabriziopandini commented Mar 8, 2021

srm09 commented Mar 8, 2021

k8s-ci-robot commented Mar 24, 2021 •

edited

Loading

srm09 commented Mar 24, 2021

fabriziopandini commented Mar 24, 2021

fabriziopandini commented Mar 24, 2021

k8s-ci-robot commented Mar 24, 2021

🌱 E2E test to upgrade workload cluster #4130

🌱 E2E test to upgrade workload cluster #4130

Conversation

srm09 commented Jan 28, 2021 • edited Loading

srm09 commented Jan 28, 2021

neolit123 left a comment • edited Loading

Choose a reason for hiding this comment

srm09 commented Feb 1, 2021

srm09 commented Feb 1, 2021

srm09 commented Feb 1, 2021

vincepri commented Feb 3, 2021

fabriziopandini Feb 4, 2021

Choose a reason for hiding this comment

srm09 Feb 5, 2021

Choose a reason for hiding this comment

wfernandes left a comment

Choose a reason for hiding this comment

srm09 commented Feb 5, 2021

wfernandes left a comment

Choose a reason for hiding this comment

fabriziopandini commented Feb 8, 2021

srm09 commented Feb 24, 2021

srm09 commented Feb 24, 2021

fabriziopandini commented Feb 25, 2021

srm09 commented Mar 1, 2021

srm09 commented Mar 2, 2021

vincepri commented Mar 2, 2021

fabriziopandini commented Mar 4, 2021

fabriziopandini commented Mar 4, 2021

fabriziopandini commented Mar 5, 2021

srm09 commented Mar 8, 2021

fabriziopandini commented Mar 8, 2021

srm09 commented Mar 8, 2021

k8s-ci-robot commented Mar 24, 2021 • edited Loading

srm09 commented Mar 24, 2021

fabriziopandini commented Mar 24, 2021

fabriziopandini commented Mar 24, 2021

k8s-ci-robot commented Mar 24, 2021

srm09 commented Jan 28, 2021 •

edited

Loading

neolit123 left a comment •

edited

Loading

k8s-ci-robot commented Mar 24, 2021 •

edited

Loading