Adds periodic job to test CAPI workload cluster upgrades #20720

srm09 · 2021-02-03T19:01:50Z

This patch adds new periodic prow jobs to test CAPI workload cluster upgrades between different supported kubernetes versions.

Fixes: kubernetes-sigs/cluster-api#4043

k8s-ci-robot · 2021-02-03T19:01:57Z

Welcome @srm09!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-02-03T19:01:58Z

Hi @srm09. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

srm09 · 2021-02-03T19:02:45Z

/cc @fabriziopandini

fabriziopandini · 2021-02-04T15:05:19Z

/ok-to-test

config/jobs/kubernetes-sigs/cluster-api/cluster-api-upgrades-main.yaml

fabriziopandini · 2021-02-04T15:32:49Z

/hold
for kubernetes-sigs/cluster-api#4130 to merge

config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml

fabriziopandini · 2021-02-05T10:13:46Z

config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml

+          cpu: 7300m
+  annotations:
+    testgrid-dashboards: sig-cluster-lifecycle-cluster-api
+    testgrid-tab-name: capi-workload-upgrade-1-19-1-20


in order to be consistent with the current naming convention in https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api

Suggested change

testgrid-tab-name: capi-workload-upgrade-1-19-1-20

testgrid-tab-name: capi-e2e-main-1-19-1-20

@vincepri opinions?

srm09 · 2021-02-05T19:22:33Z

@fabriziopandini Does it make sense to keep this job pull-cluster-api-e2e-k8s-latest-main, now that we have a periodic test to test the same upgrade scenario?

config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-main.yaml

fabriziopandini · 2021-02-08T10:28:12Z

one last nit then lgtm for me; also please squash commits

@fabriziopandini Does it make sense to keep this job pull-cluster-api-e2e-k8s-latest-main, now that we have a periodic test to test the same upgrade scenario?

see #20720 (comment)

fabriziopandini · 2021-02-08T19:46:52Z

/lgtm

srm09 · 2021-02-08T19:57:23Z

/unhold
@vincepri PTAL at your convenience.

config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml

config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-main.yaml

fabriziopandini

@srm09 I'm trying to unblock this so we can have a better signal while doing v1alpha4 changes.

In order to address @CecileRobertMichon and @vincepri concerns, I have suggested using release labels, so maintenance on these jobs will be reduced to the minimum.
Let me know if there are questions on these changes/other pending comments

config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml

fabriziopandini · 2021-02-24T21:12:51Z

change lgtm to me, please squash commits

This patch adds new periodic prow jobs to test CAPI workload cluster upgrades between different supported kubernetes versions. Signed-off-by: Sagar Muchhal <[email protected]> Co-authored-by: Fabrizio Pandini <[email protected]>

fabriziopandini · 2021-03-08T21:43:20Z

/lgtm

fabriziopandini · 2021-03-24T20:47:13Z

/approve

vincepri · 2021-03-24T21:11:20Z

/approve

k8s-ci-robot · 2021-03-24T21:11:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, srm09, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~config/jobs/kubernetes-sigs/cluster-api/OWNERS~~ [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2021-03-24T21:23:34Z

@srm09: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

key cluster-api-periodics-main-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml
key cluster-api-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml
key cluster-api-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-main.yaml

In response to this:

This patch adds new periodic prow jobs to test CAPI workload cluster upgrades between different supported kubernetes versions.

Fixes: kubernetes-sigs/cluster-api#4043

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 3, 2021

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 3, 2021

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 3, 2021

k8s-ci-robot requested review from davidewatson and justinsb February 3, 2021 19:02

k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 3, 2021

k8s-ci-robot requested a review from fabriziopandini February 3, 2021 19:02

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 4, 2021

fabriziopandini reviewed Feb 4, 2021

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2021

fabriziopandini reviewed Feb 5, 2021

View reviewed changes

srm09 mentioned this pull request Feb 5, 2021

🌱 E2E test to upgrade workload cluster kubernetes-sigs/cluster-api#4130

Merged

fabriziopandini reviewed Feb 8, 2021

View reviewed changes

config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-main.yaml Outdated Show resolved Hide resolved

srm09 force-pushed the add-cluster-api-upgrade-e2e-test branch from 7a92067 to ac1cc31 Compare February 8, 2021 19:34

k8s-ci-robot assigned fabriziopandini Feb 8, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2021

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2021

CecileRobertMichon reviewed Feb 10, 2021

View reviewed changes

config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml Show resolved Hide resolved

CecileRobertMichon reviewed Feb 10, 2021

View reviewed changes

config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-main.yaml Show resolved Hide resolved

fabriziopandini reviewed Feb 23, 2021

View reviewed changes

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2021

Adds periodic job to test CAPI upgrades

f513b75

This patch adds new periodic prow jobs to test CAPI workload cluster upgrades between different supported kubernetes versions. Signed-off-by: Sagar Muchhal <[email protected]> Co-authored-by: Fabrizio Pandini <[email protected]>

srm09 force-pushed the add-cluster-api-upgrade-e2e-test branch from 6f3ebec to f513b75 Compare March 8, 2021 20:40

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2021

k8s-ci-robot merged commit 6fd62d1 into kubernetes:master Mar 24, 2021

k8s-ci-robot added this to the v1.21 milestone Mar 24, 2021

srm09 deleted the add-cluster-api-upgrade-e2e-test branch March 24, 2021 21:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds periodic job to test CAPI workload cluster upgrades #20720

Adds periodic job to test CAPI workload cluster upgrades #20720

srm09 commented Feb 3, 2021 •

edited

Loading

k8s-ci-robot commented Feb 3, 2021

k8s-ci-robot commented Feb 3, 2021

srm09 commented Feb 3, 2021

fabriziopandini commented Feb 4, 2021

fabriziopandini commented Feb 4, 2021

fabriziopandini Feb 5, 2021

srm09 commented Feb 5, 2021

fabriziopandini commented Feb 8, 2021

fabriziopandini commented Feb 8, 2021

srm09 commented Feb 8, 2021

fabriziopandini left a comment

fabriziopandini commented Feb 24, 2021

fabriziopandini commented Mar 8, 2021

fabriziopandini commented Mar 24, 2021

vincepri commented Mar 24, 2021

k8s-ci-robot commented Mar 24, 2021

k8s-ci-robot commented Mar 24, 2021

	testgrid-tab-name: capi-workload-upgrade-1-19-1-20
	testgrid-tab-name: capi-e2e-main-1-19-1-20

Adds periodic job to test CAPI workload cluster upgrades #20720

Adds periodic job to test CAPI workload cluster upgrades #20720

Conversation

srm09 commented Feb 3, 2021 • edited Loading

k8s-ci-robot commented Feb 3, 2021

k8s-ci-robot commented Feb 3, 2021

srm09 commented Feb 3, 2021

fabriziopandini commented Feb 4, 2021

fabriziopandini commented Feb 4, 2021

fabriziopandini Feb 5, 2021

Choose a reason for hiding this comment

srm09 commented Feb 5, 2021

fabriziopandini commented Feb 8, 2021

fabriziopandini commented Feb 8, 2021

srm09 commented Feb 8, 2021

fabriziopandini left a comment

Choose a reason for hiding this comment

fabriziopandini commented Feb 24, 2021

fabriziopandini commented Mar 8, 2021

fabriziopandini commented Mar 24, 2021

vincepri commented Mar 24, 2021

k8s-ci-robot commented Mar 24, 2021

k8s-ci-robot commented Mar 24, 2021

srm09 commented Feb 3, 2021 •

edited

Loading