-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 E2E conformance tests now use kind network #4042
🐛 E2E conformance tests now use kind network #4042
Conversation
/milestone v0.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/milestone v0.4.0
/approve cancel |
87a2d01
to
177bd83
Compare
/test pull-cluster-api-e2e-full-main |
177bd83
to
2031398
Compare
/test pull-cluster-api-e2e-full-main |
@fabriziopandini Out of curiosity, did anything change from the earlier run? I don't notice major changes in the diff |
@vincepri there was only a small change in the docker exec args order (see networkArg position): from
to
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR fixes the e2e conformance test for working with CAPD after this has been changed to use the kind network
It also fixes v1alpha4 test running locally on mac os.