Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 E2E conformance tests now use kind network #4042

Merged

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR fixes the e2e conformance test for working with CAPD after this has been changed to use the kind network
It also fixes v1alpha4 test running locally on mac os.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 4, 2021
@fabriziopandini
Copy link
Member Author

/milestone v0.4.0
/test pull-cluster-api-e2e-full-main

@vincepri vincepri changed the title 🐛 fix e2e conformance test 🐛 E2E conformance tests now use kind network Jan 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Jan 4, 2021
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 4, 2021
@vincepri
Copy link
Member

vincepri commented Jan 4, 2021

/approve cancel

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2021
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@vincepri
Copy link
Member

vincepri commented Jan 4, 2021

@fabriziopandini Out of curiosity, did anything change from the earlier run? I don't notice major changes in the diff

@fabriziopandini
Copy link
Member Author

@vincepri there was only a small change in the docker exec args order (see networkArg position):

from

e2eCmd := exec.Command("docker", "run", "--user", userArg, kubeConfigVolumeMount, outputVolumeMount, viperVolumeMount, "-t", input.ConformanceImage, networkArg)

to

e2eCmd := exec.Command("docker", "run", "--user", userArg, kubeConfigVolumeMount, outputVolumeMount, viperVolumeMount, "-t", networkArg, input.ConformanceImage)

@vincepri
Copy link
Member

vincepri commented Jan 4, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 011d92c into kubernetes-sigs:master Jan 4, 2021
@fabriziopandini fabriziopandini deleted the fix-e2e-conformance branch January 5, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants